[ovs-dev] [PATCH] vconn-stream: Always call the stream's run function from vconn_stream_run().

The stream's run function ensures that data buffered in the stream itself gets pushed to the network. Only the SSL stream class has such a run function, which means that SSL stream data failed to be pushed to the remote peer in a timely manner in some cases. Many thanks to Alex Yip for narrowing

Re: [ovs-dev] [PATCH] vconn-stream: Always call the stream's run function from vconn_stream_run().

Looks good. --Justin On Jul 8, 2011, at 9:14 AM, Ben Pfaff wrote: > The stream's run function ensures that data buffered in the stream itself > gets pushed to the network. Only the SSL stream class has such a run > function, which means that SSL stream data failed to be pushed to the > remote

Re: [ovs-dev] [PATCH] vconn-stream: Always call the stream's run function from vconn_stream_run().

Thanks, I've pushed this to master and soon will push to branch-1.1. On Fri, Jul 08, 2011 at 09:36:07AM -0700, Justin Pettit wrote: > Looks good. > > --Justin > > > On Jul 8, 2011, at 9:14 AM, Ben Pfaff wrote: > > > The stream's run function ensures that data buffered in the stream itself > >

Re: [ovs-dev] OpenFlow 1.0 emergency mode supported?

On Fri, Jul 08, 2011 at 02:18:42PM +0900, Romain Lenglet wrote: > On Thu, Jul 7, 2011 at 11:44 PM, Ben Pfaff wrote: > > > On Thu, Jul 07, 2011 at 06:36:32PM +0900, Tamura, Yoshiaki wrote: > > > I've been playing around with OVS 1.1 and have a question regarding > > > emergency mode specified in O

[ovs-dev] [PATCH] packets: Remove unneeded !! from eth_addr_is_local().

There's no value in using !! on an operand of && or || as done here. --- lib/packets.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/packets.h b/lib/packets.h index 20065ad..8e13a25 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -56,8 +56,8 @@ static inline boo

Re: [ovs-dev] [PATCH] packets: Remove unneeded !! from eth_addr_is_local().

Looks good. --Justin On Jul 8, 2011, at 10:47 AM, Ben Pfaff wrote: > There's no value in using !! on an operand of && or || as done here. > --- > lib/packets.h |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/packets.h b/lib/packets.h > index 20065ad..8e13a25

[ovs-dev] [PATCH] ovs-vsctl: Log better warnings for duplicate ports and interfaces.

The database prevents multiple ports or interfaces with a single name, but duplicates can still occur if, for example, two bridges' "ports" columns both point to a single Port record. The existing warning just says in this case that the database contains a duplicate port name. This prompts users

Re: [ovs-dev] [PATCH] packets: Remove unneeded !! from eth_addr_is_local().

Thanks, I pushed this to master. On Fri, Jul 08, 2011 at 10:48:47AM -0700, Justin Pettit wrote: > Looks good. > > --Justin > > > On Jul 8, 2011, at 10:47 AM, Ben Pfaff wrote: > > > There's no value in using !! on an operand of && or || as done here. > > --- > > lib/packets.h |4 ++-- > > 1

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

On Sun, Jul 3, 2011 at 5:01 PM, Valient Gough wrote: > Add tunnel key support to CAPWAP vport.  Uses the optional WSI field in a > CAPWAP header to store a 64bit key.  It can also be used without keys, in > which > case it is backward compatible with the old code.  Documentation about the > WSI f

[ovs-dev] [PATCH 1/2] ovsdb: Remove useless "return; " in ovsdb_jsonrpc_session_get_status().

--- ovsdb/jsonrpc-server.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 379fc52..e74c42b 100644 --- a/ovsdb/jsonrpc-server.c +++ b/ovsdb/jsonrpc-server.c @@ -475,7 +475,6 @@ ovsdb_jsonrpc_session_get_status(const str

[ovs-dev] [PATCH 2/2] INSTALL.bridge: Fix suggested ovs-brcompatd invocation.

ovs-brcompatd no longer accepts any non-option arguments. Also, -vANY:console:EMER is unnecessary, because --detach now implies disabling logging to the console. --- INSTALL.bridge |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/INSTALL.bridge b/INSTALL.bridge index 650

Re: [ovs-dev] [PATCH 2/2] INSTALL.bridge: Fix suggested ovs-brcompatd invocation.

Looks Good. On Fri, Jul 8, 2011 at 16:57, Ben Pfaff wrote: > ovs-brcompatd no longer accepts any non-option arguments.  Also, > -vANY:console:EMER is unnecessary, because --detach now implies disabling > logging to the console. > --- >  INSTALL.bridge |    3 +-- >  1 files changed, 1 insertions(+

Re: [ovs-dev] [PATCH 1/2] ovsdb: Remove useless "return; " in ovsdb_jsonrpc_session_get_status().

Looks Good. return; Ethan On Fri, Jul 8, 2011 at 16:57, Ben Pfaff wrote: > --- >  ovsdb/jsonrpc-server.c |    1 - >  1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c > index 379fc52..e74c42b 100644 > --- a/ovsdb/jsonrpc-server.c >

Re: [ovs-dev] [PATCH 2/2] INSTALL.bridge: Fix suggested ovs-brcompatd invocation.

Thank you, I pushed these two patches. On Fri, Jul 08, 2011 at 05:00:14PM -0700, Ethan Jackson wrote: > Looks Good. > > On Fri, Jul 8, 2011 at 16:57, Ben Pfaff wrote: > > ovs-brcompatd no longer accepts any non-option arguments. ?Also, > > -vANY:console:EMER is unnecessary, because --detach now