I wanted to let everyone know that there is a #openvswitch IRC channel on
irc.freenode.net. This is a great place to discuss OVS and is frequented by
some of the OVS developers (okay, mostly Ben, but that's really all you need).
I'd encourage you to check it out and join in on the conversation
On Fri, 1 Jul 2011 10:27:25 +0900
Simon Horman wrote:
> Hi Chuck,
>
> I notice that you have added openvswitch-datapath-dkms to
> the Ubuntu openvswitch package. Do you have any interest
> in submitting this upstream? Are there any caveats that
> you are aware of? Do you think it should replace/
On Thu, Jun 30, 2011 at 06:02:16PM -0700, Andrew Evans wrote:
> Updates to status-related columns in the Controller table can be lost if there
> are multiple bridges with different sets of controllers. This commit fixes
> this
> behavior by first accumulating status for all controllers on all brid
On Thu, Jun 30, 2011 at 06:19:37PM -0700, Andrew Evans wrote:
> Make ofproto_free_ofproto_controller_info() just a passthrough to
> connmgr_free_controller_info() so the allocation and freeing of memory in the
> controller info structure is done in the same place.
Looks good, thank you.
__
On Thu, Jun 30, 2011 at 06:49:46PM -0700, Ethan Jackson wrote:
> According to the following documentation, we should be sending
> gratuitous ARPs when rebalancing causes us to shift traffic to a
> different slave.
>
> http://support.citrix.com/article/CTX124421
I guess it can't hurt, but I'm not
If the netdev_open() fails then iface->netdev will be NULL and
iface_refresh_stats() will cause a null pointer dereference in
netdev_get_stats().
Fixes a problem introduced by commit 1101a0b47 "bridge: Populate interface
status/statistics as soon as a port is added."
Reported-by: Aaron Rosen
---
Given the invalid input , some versions of Python report as the
invalid sequence and other versions report as the invalid sequence.
Similarly, given input , some report and others report
as the invalid sequence. This caused spurious test failures for
the test "no invalid UTF-8 sequences in str
I should add that this was the only patch I needed to apply to get OVS
to build and pass the testsuite on Ubuntu 10.04 (LTS).
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Looks good.
--Justin
On Jul 1, 2011, at 10:14 AM, Ben Pfaff wrote:
> If the netdev_open() fails then iface->netdev will be NULL and
> iface_refresh_stats() will cause a null pointer dereference in
> netdev_get_stats().
>
> Fixes a problem introduced by commit 1101a0b47 "bridge: Populate interf
Pushed.
On Fri, Jul 01, 2011 at 10:17:14AM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Jul 1, 2011, at 10:14 AM, Ben Pfaff wrote:
>
> > If the netdev_open() fails then iface->netdev will be NULL and
> > iface_refresh_stats() will cause a null pointer dereference in
> > netd
On Fri, 2011-07-01 at 09:05 -0700, Ben Pfaff wrote:
> Good catch! Thank you, this looks good.
Thanks for reviewing. I pushed this.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, 2011-07-01 at 09:09 -0700, Ben Pfaff wrote:
> Looks good, thank you.
Thanks, I've pushed this.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I didn't check the kernel implementation so I don't know what they
actually do on the wire.
I'm not particularly convinced that this is important, but Sanjay
thinks it is. It was easy enough to write up so I thought we could
discuss it on the dev list. I'm not married to the patch either way.
T
---
utilities/ovs-ofctl.8.in |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 433731c..9e96a2b 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
@@ -596,6 +596,9 @@ omitted, then the entire packe
Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks. Pushed.
--Justin
On Jul 1, 2011, at 1:18 PM, Ben Pfaff wrote:
> Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Jul 1, 2011 at 11:07 AM, Ethan Jackson wrote:
> I'm not particularly convinced that this is important, but Sanjay
> thinks it is. It was easy enough to write up so I thought we could
> discuss it on the dev list. I'm not married to the patch either way.
> Though agree I don't really see
On Fri, Jul 01, 2011 at 02:04:38PM -0700, Jesse Gross wrote:
> On Fri, Jul 1, 2011 at 11:07 AM, Ethan Jackson wrote:
> > I'm not particularly convinced that this is important, but Sanjay
> > thinks it is. ??It was easy enough to write up so I thought we could
> > discuss it on the dev list. ??I'm
---
PORTING | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/PORTING b/PORTING
index 34c71f4..3dd0bfc 100644
--- a/PORTING
+++ b/PORTING
@@ -53,7 +53,7 @@ these components should not need to be modified as part of a
port:
- "ofproto" is the Open vSwitch l
To be more consistent with other providers, rename "private.h" to
"ofproto-provider.h".
---
PORTING |6 +++---
ofproto/automake.mk |4 ++--
ofproto/connmgr.c |2 +-
ofproto/fail-open.c
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Jul 01, 2011 at 02:18:50PM -0700, Justin Pettit wrote:
> To be more consistent with other providers, rename "private.h" to
> "ofproto-provider.h".
Looks good, thank you.
I didn't look for missing changes, I assume you used "grep".
___
dev mailin
On Jul 1, 2011, at 2:31 PM, Ben Pfaff wrote:
> On Fri, Jul 01, 2011 at 02:18:50PM -0700, Justin Pettit wrote:
>> To be more consistent with other providers, rename "private.h" to
>> "ofproto-provider.h".
>
> Looks good, thank you.
>
> I didn't look for missing changes, I assume you used "grep".
On Thu, Jun 30, 2011 at 02:57:29PM -0700, Ben Pfaff wrote:
> ovs-bugtool is no longer Debian-specific, so install it everywhere. (On
> XenServer, specifically, we do not install it, because there xen-bugtool
> already exists.)
I folded in the following incremental fix:
commit 5dae12c5202fa366dd9
Commit 14c3b136 "debian: Remove corekeeper package" removed the
var/log/core directory from the Debian packaging, but I missed this part.
---
debian/rules |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/rules b/debian/rules
index 76d11a0..357285f 100755
--- a/debia
Looks good.
--Justin
On Jul 1, 2011, at 2:58 PM, Ben Pfaff wrote:
> Commit 14c3b136 "debian: Remove corekeeper package" removed the
> var/log/core directory from the Debian packaging, but I missed this part.
> ---
> debian/rules |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
Looks good. Thanks.
--Justin
On Jul 1, 2011, at 10:14 AM, Ben Pfaff wrote:
> Given the invalid input , some versions of Python report as the
> invalid sequence and other versions report as the invalid sequence.
> Similarly, given input , some report and others report
> as the invalid seque
All of the xen-bugtool plugins that OVS has previously installed only under
XenServer are equally useful with Debian and other distributions, so
this commit installs and uses them everywhere.
---
Makefile.am|6 +++-
configure.ac
28 matches
Mail list logo
