Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-02 Thread Ben Pfaff
On Tue, Feb 02, 2016 at 02:06:22PM +0300, Ilya Maximets wrote: > > Then you need to validate that the socket is in a directory reserved for > > sockets, like other parts of OVS do. > > > > Seriously it's not acceptable to have OVS break if you kill it and > > restart it. That's just crappy, lazy

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-02 Thread Ilya Maximets
On 02.02.2016 14:06, Ilya Maximets wrote: >> Then you need to validate that the socket is in a directory reserved for >> sockets, like other parts of OVS do. >> >> Seriously it's not acceptable to have OVS break if you kill it and >> restart it. That's just crappy, lazy programming. > > This is

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-02 Thread Ilya Maximets
> Then you need to validate that the socket is in a directory reserved for > sockets, like other parts of OVS do. > > Seriously it's not acceptable to have OVS break if you kill it and > restart it. That's just crappy, lazy programming. This is not my code. I'm just trying to fix it. > Figure o

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-01 Thread Ben Pfaff
On Tue, Feb 02, 2016 at 07:58:32AM +0300, Ilya Maximets wrote: > On 01.02.2016 21:31, Ben Pfaff wrote: > > On Mon, Feb 01, 2016 at 10:24:29AM +0300, Ilya Maximets wrote: > >> On 29.01.2016 22:02, Guru Shetty wrote: > >>> This reverts commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f. > >>> > >>> Reas

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-01 Thread Ilya Maximets
On 01.02.2016 21:31, Ben Pfaff wrote: > On Mon, Feb 01, 2016 at 10:24:29AM +0300, Ilya Maximets wrote: >> On 29.01.2016 22:02, Guru Shetty wrote: >>> This reverts commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f. >>> >>> Reason: >>> Calling 'ovs-appctl exit' on ovs-vswitchd will cause ovs-vswitchd >

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-01 Thread Ben Pfaff
On Mon, Feb 01, 2016 at 10:24:29AM +0300, Ilya Maximets wrote: > On 29.01.2016 22:02, Guru Shetty wrote: > > This reverts commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f. > > > > Reason: > > Calling 'ovs-appctl exit' on ovs-vswitchd will cause ovs-vswitchd > > to destroy all the ports from the dat

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-01 Thread Ben Pfaff
On Mon, Feb 01, 2016 at 08:05:33AM -0800, Guru Shetty wrote: > On 31 January 2016 at 23:24, Ilya Maximets wrote: > > > On 29.01.2016 22:02, Guru Shetty wrote: > > > This reverts commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f. > > > > > > Reason: > > > Calling 'ovs-appctl exit' on ovs-vswitchd wi

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-02-01 Thread Guru Shetty
On 31 January 2016 at 23:24, Ilya Maximets wrote: > On 29.01.2016 22:02, Guru Shetty wrote: > > This reverts commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f. > > > > Reason: > > Calling 'ovs-appctl exit' on ovs-vswitchd will cause ovs-vswitchd > > to destroy all the ports from the datapath. This

Re: [ovs-dev] Revert "ovs-lib: Try to call exit before killing."

2016-01-31 Thread Ilya Maximets
On 29.01.2016 22:02, Guru Shetty wrote: > This reverts commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f. > > Reason: > Calling 'ovs-appctl exit' on ovs-vswitchd will cause ovs-vswitchd > to destroy all the ports from the datapath. This is an unacceptable > behavior while restarting the daemons. Ki