Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-05 Thread Samuel Ghinet
n Pfaff; Eitan Eliahu; dev@openvswitch.org Subject: Re: [ovs-dev] Queuing packets to userspace and NBL info problem On Aug 5, 2014, at 7:24 AM, Samuel Ghinet wrote: > Hello Nithin, > > Even with having this IPSec problem: > a) The other NBL info items are still standing. > b) There is

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-05 Thread Nithin Raju
On Aug 5, 2014, at 7:24 AM, Samuel Ghinet wrote: > Hello Nithin, > > Even with having this IPSec problem: > a) The other NBL info items are still standing. > b) There is no IPSec worry for the cases where we do not do tunneling (I > believe). Yes and No. In general, we don't need to complete

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-05 Thread Eitan Eliahu
- From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] Sent: Tuesday, August 05, 2014 7:24 AM To: Nithin Raju; Ben Pfaff; Eitan Eliahu Cc: dev@openvswitch.org Subject: RE: [ovs-dev] Queuing packets to userspace and NBL info problem Hello Nithin, Even with having this IPSec problem: a) The other

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-05 Thread Samuel Ghinet
Ben Pfaff; Eitan Eliahu Cc: dev@openvswitch.org Subject: RE: [ovs-dev] Queuing packets to userspace and NBL info problem This "issue" is not limited to missed packets only. This is applicable when there is a flow in the kernel as well. When a VIF requests IPsec offload, and such

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-05 Thread Nithin Raju
behalf of Samuel Ghinet Sent: Tuesday, August 5, 2014 5:08 AM To: Ben Pfaff; Eitan Eliahu Cc: dev@openvswitch.org Subject: Re: [ovs-dev] Queuing packets to userspace and NBL info problem "Most of the items on the list seem to be related to offloads. The kernel module should complete off

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-05 Thread Samuel Ghinet
_ From: Ben Pfaff [b...@nicira.com] Sent: Tuesday, August 05, 2014 6:19 AM To: Eitan Eliahu Cc: Samuel Ghinet; dev@openvswitch.org Subject: Re: [ovs-dev] Queuing packets to userspace and NBL info problem Yes. In addition, some packets may get sent to an OpenFlow controller. On Sun, Aug 03

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-04 Thread Ben Pfaff
Yes. In addition, some packets may get sent to an OpenFlow controller. On Sun, Aug 03, 2014 at 06:52:55PM +, Eitan Eliahu wrote: > > Hi Samuel, my initial implementation was holding a reference to NBLs > which were indicated to user mode. However, there is an issue with > that as in general

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-04 Thread Ben Pfaff
On Sun, Aug 03, 2014 at 06:39:04PM +, Samuel Ghinet wrote: > Well, things such as IPSec offload, and more obscure stuff such as: > "any media-specific out-of-band data that accompanies the NET_BUFFER > structures that are associated with the NET_BUFFER_LIST structure." > > The complete list,

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-03 Thread Eitan Eliahu
Hi Samuel, my initial implementation was holding a reference to NBLs which were indicated to user mode. However, there is an issue with that as in general not all packets are returned to back to the kernel and some packets could be modified in user space. Perhaps, Ben could confirm? Thanks, Ei

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-03 Thread Samuel Ghinet
com] Sent: Sunday, August 03, 2014 8:10 PM To: Samuel Ghinet Cc: dev@openvswitch.org Subject: Re: [ovs-dev] Queuing packets to userspace and NBL info problem On Sun, Aug 03, 2014 at 05:06:14PM +, Samuel Ghinet wrote: > I think this is a problem that both implementations suffer of: Namely, &g

Re: [ovs-dev] Queuing packets to userspace and NBL info problem

2014-08-03 Thread Ben Pfaff
On Sun, Aug 03, 2014 at 05:06:14PM +, Samuel Ghinet wrote: > I think this is a problem that both implementations suffer of: Namely, > when we give a packet to the userspace, we strip off the NBL info > array from it. In other words, when the packet gets back from the > userspace and must be out