Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-18 Thread Ben Pfaff
On Wed, Mar 18, 2015 at 03:29:37PM +0100, Jonathan Vestin wrote: > Thank you for the patch, it is working now. I have implemented tc_load > for each qdisc, correct some of the code style, added the NEWS entry > and changed vswitch.xml. If everything checks out nicely I will submit > the patch to de

Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-18 Thread Jonathan Vestin
Thank you for the patch, it is working now. I have implemented tc_load for each qdisc, correct some of the code style, added the NEWS entry and changed vswitch.xml. If everything checks out nicely I will submit the patch to dev. However, since it depends on your patch, is there anything special

Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-13 Thread Ben Pfaff
Thanks for the additional information. I did some more experiments with your example. I posted a v2 of my patch: http://openvswitch.org/pipermail/dev/2015-March/052394.html You'll need to implement the tc_load callback now since otherwise you'll get a segfault when tc_query_qdisc() tries

Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-11 Thread Jonathan Vestin
Thank you for your fast reply and fix. I applied it and it still doesn't fix my problem. Some investigation and my problem seems to be that in tc_query_qdisc, the call to tc_transact returns error 2 (No such file or directory). I try to trigger tc_load with the following script: tc qdisc del de

Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-10 Thread Ben Pfaff
On Tue, Mar 10, 2015 at 10:07:31PM +0100, Jonathan Vestin wrote: > Ok, quite some things to do, I will fix the things you mentioned after > sorting out the tc_load problem. > > Regarding tc_load: > See the comment in: tc_parse_qdisc at 4414 to 4420: > * To avoid the OOPS, we must not make a reque

Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-10 Thread Jonathan Vestin
openvswitch.org Date: Tue, 10 Mar 2015 10:54:35 -0700 Subject: Re: [ovs-dev] Patch adding additional QoS strategies to OVS On Tue, Mar 10, 2015 at 04:22:12PM +0100, Jonathan Vestin wrote: > Hello, I finally made my changes to OVS into a patch. I am a beginner in doing this kind of low-level p

Re: [ovs-dev] Patch adding additional QoS strategies to OVS

2015-03-10 Thread Ben Pfaff
On Tue, Mar 10, 2015 at 04:22:12PM +0100, Jonathan Vestin wrote: > Hello, I finally made my changes to OVS into a patch. I am a beginner in > doing this kind of low-level programming, and it is my first patch to any > open source project, so before submitting a patch, it would be nice with some