Re: [ovs-dev] [tos 3/3] vswitch: Implement dscp column of the Queue table.

2011-11-23 Thread Ethan Jackson
Awesome, I'll merge this. Ethan On Wed, Nov 23, 2011 at 12:04, Ben Pfaff wrote: > On Wed, Nov 23, 2011 at 11:28:32AM -0800, Ethan Jackson wrote: >> Here's an incremental. > > Thanks, it looks good. > ___ dev mailing list dev@openvswitch.org http://open

Re: [ovs-dev] [tos 3/3] vswitch: Implement dscp column of the Queue table.

2011-11-23 Thread Ben Pfaff
On Wed, Nov 23, 2011 at 11:28:32AM -0800, Ethan Jackson wrote: > Here's an incremental. Thanks, it looks good. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [tos 3/3] vswitch: Implement dscp column of the Queue table.

2011-11-23 Thread Ethan Jackson
Here's an incremental. --- ofproto/ofproto-dpif.c | 55 +++ ofproto/ofproto-provider.h |8 -- ofproto/ofproto.c |8 -- vswitchd/vswitch.xml |2 +- 4 files changed, 40 insertions(+), 33 deletions(-) diff --git a/ofpr

Re: [ovs-dev] [tos 3/3] vswitch: Implement dscp column of the Queue table.

2011-11-23 Thread Ethan Jackson
> I wonder whether priority_node is the most informative possible name. > Both "priority" and "node" are very generic computer science terms and > so the name priority_node doesn't pop out as being descriptive.  Maybe > something like "queue_marking", "qos_to_dscp", etc. would be more > meaningful.

Re: [ovs-dev] [tos 3/3] vswitch: Implement dscp column of the Queue table.

2011-11-23 Thread Ben Pfaff
On Tue, Nov 22, 2011 at 04:29:36PM -0800, Ethan Jackson wrote: > The dscp column of the queue table instructs Open vSwitch to mark > all traffic egressing the queue with the given DSCP bits in its tos > field. > > Bug #7046. Could you move the hmap_node to the start of struct priority_node? hmap_