Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Ben Pfaff
On Wed, Dec 11, 2013 at 05:55:35PM -0800, Ben Pfaff wrote: > On Wed, Dec 11, 2013 at 04:09:57PM -0800, Jarno Rajahalme wrote: > > > > On Dec 11, 2013, at 3:14 PM, Ben Pfaff wrote: > > > > > On Wed, Dec 11, 2013 at 02:17:13PM -0800, Jarno Rajahalme wrote: > > >> While testing the code I accidenta

Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Ben Pfaff
On Wed, Dec 11, 2013 at 04:09:57PM -0800, Jarno Rajahalme wrote: > > On Dec 11, 2013, at 3:14 PM, Ben Pfaff wrote: > > > On Wed, Dec 11, 2013 at 02:17:13PM -0800, Jarno Rajahalme wrote: > >> While testing the code I accidentally requested a change in the interface > >> type (to dummy), like thi

Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Jarno Rajahalme
On Dec 11, 2013, at 3:14 PM, Ben Pfaff wrote: > On Wed, Dec 11, 2013 at 02:17:13PM -0800, Jarno Rajahalme wrote: >> While testing the code I accidentally requested a change in the interface >> type (to dummy), like this: >> >> # ovs-vsctl add-br br0 >> # ovs-vsctl add-port br0 p1 -- set Interf

Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Ben Pfaff
On Wed, Dec 11, 2013 at 01:27:25PM -0800, Jarno Rajahalme wrote: > > On Dec 10, 2013, at 11:20 PM, Ben Pfaff wrote: > > > This greatly simplifies the reconfiguration code, making it much easier > > to understand and modify. The old multi-pass configuration had the > > property that it didn't de

Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Ben Pfaff
On Wed, Dec 11, 2013 at 02:17:13PM -0800, Jarno Rajahalme wrote: > While testing the code I accidentally requested a change in the interface > type (to dummy), like this: > > # ovs-vsctl add-br br0 > # ovs-vsctl add-port br0 p1 -- set Interface p1 type=internal > # ovs-vsctl -- set Interface p1 t

Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Ethan Jackson
I'm happy with this once the segfault is fixed. Ethan On Tue, Dec 10, 2013 at 11:20 PM, Ben Pfaff wrote: > This greatly simplifies the reconfiguration code, making it much easier > to understand and modify. The old multi-pass configuration had the > property that it didn't delay block packet pr

Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Jarno Rajahalme
Ben, I did some additional testing and accidentally found out a problem with this patch: While testing the code I accidentally requested a change in the interface type (to dummy), like this: # ovs-vsctl add-br br0 # ovs-vsctl add-port br0 p1 -- set Interface p1 type=internal # ovs-vsctl -- set

Re: [ovs-dev] [port-renumbering 7/8] bridge: Reconfigure in single pass.

2013-12-11 Thread Jarno Rajahalme
On Dec 10, 2013, at 11:20 PM, Ben Pfaff wrote: > This greatly simplifies the reconfiguration code, making it much easier > to understand and modify. The old multi-pass configuration had the > property that it didn't delay block packet processing as much, but that's > not much of a worry anymore