Re: [ovs-dev] [patch v2] openvswitch: using a bit shift as a mask

2016-03-21 Thread Jarno Rajahalme
I just sent the patch to netfilter-devel and kernel-janitors with you as Reported-by. Jarno > On Mar 19, 2016, at 5:09 AM, Dan Carpenter wrote: > > It doesn't make sense to apply my patch. Can you please send your patch > but give me a Reported-by: tag? > > regards, > dan carpenter > ___

Re: [ovs-dev] [patch v2] openvswitch: using a bit shift as a mask

2016-03-19 Thread Dan Carpenter
It doesn't make sense to apply my patch. Can you please send your patch but give me a Reported-by: tag? regards, dan carpenter ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [patch v2] openvswitch: using a bit shift as a mask

2016-03-18 Thread Jarno Rajahalme
Dan, Thanks again for finding this bug! Running the OVS datapath testsuite I found that the use of a bit shift as a mask actually hid another bug: I had assumed that the IPS_EXPECTED_BIT is set for the first packet of a new connection only, while its definition is accompanied with a comment sta