Ben,
On my reading the first three patches seem fine. I thought that the fact that
the semantics of the struct flow_metadata has changed from "exportable
metadata" to "all metadata, some of which is exportable to controllers"
deserves a note somewhere, but then the original comment on flow_meta
I agree about the "md.", but I don't know a better way in portable C.
There are some ways that I don't think are better (e.g. macros that
expand to md.in_port etc.) and ways that are not portable (e.g. the
extension described in "Unnamed struct/union fields within
structs/unions") in the GCC manual
Getting rid of mostly dummy function parameters and duplication is always nice,
but I'd like it better if there was a way not to have to see the "md."
everywhere (start to miss C++ here..). Also, since we care about the zeros at
the end of struct flow, maybe we should have them in struct flow_tn
