Re: [ovs-dev] [dscp 4/4] vswitch: Use consistent representation of DSCP bits.

2012-04-17 Thread Ethan Jackson
Thanks for the reviews, I'll merge this shortly. On Tue, Apr 17, 2012 at 13:29, Ben Pfaff wrote: > On Tue, Apr 17, 2012 at 01:27:24PM -0700, Ethan Jackson wrote: >> Here's an incremental. > > Thanks, looks good to me. ___ dev mailing list dev@openvswitc

Re: [ovs-dev] [dscp 4/4] vswitch: Use consistent representation of DSCP bits.

2012-04-17 Thread Ben Pfaff
On Tue, Apr 17, 2012 at 01:27:24PM -0700, Ethan Jackson wrote: > Here's an incremental. Thanks, looks good to me. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [dscp 4/4] vswitch: Use consistent representation of DSCP bits.

2012-04-17 Thread Ethan Jackson
Here's an incremental. --- lib/socket-util.c | 14 +++--- lib/socket-util.h |2 +- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index ca37a54..a9b3b1a 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -85,11 +85,15 @@

Re: [ovs-dev] [dscp 4/4] vswitch: Use consistent representation of DSCP bits.

2012-04-17 Thread Ben Pfaff
On Mon, Apr 16, 2012 at 02:17:52PM -0700, Ethan Jackson wrote: > There are two sensible ways to represent the 6 DSCP bits of an IP > packet. One could represent them as an integer in the range 0 to > 63. Or one could represent them as they would appear in the tos > field (0 to 63) << 2. Before t

Re: [ovs-dev] [dscp 4/4] vswitch: Use consistent representation of DSCP bits.

2012-04-16 Thread Ethan Jackson
I realized this patch should update the minor version of the ovsschema. I've folded that change in. Ethan On Mon, Apr 16, 2012 at 14:17, Ethan Jackson wrote: > There are two sensible ways to represent the 6 DSCP bits of an IP > packet.  One could represent them as an integer in the range 0 to >