Re: [ovs-dev] [RFC Patch] dpif-netdev: dpcls per in_port with sorted subtables

2016-07-07 Thread Jan Scheurich
> From: Jan Scheurich > Sent: Thursday, 07 July, 2016 10:28 > > I actually have some doubts about thread safety of the dpcls complex. My > understanding is that dpcls rules are inserted only by the owning PMD thread > itself as result of processing upcalls. But dplcs rules are removed by > revalid

Re: [ovs-dev] [RFC Patch] dpif-netdev: dpcls per in_port with sorted subtables

2016-07-07 Thread Jan Scheurich
> From: Jarno Rajahalme [mailto:ja...@ovn.org] > Sent: Monday, 04 July, 2016 14:06 > > I like this RFC patch and suggest you send a non-RFC patch after taking care > of the following: Thanks for the review. Will implement all requested changes and submit non-RFC PATCH v2 when ready. > - You sho

Re: [ovs-dev] [RFC Patch] dpif-netdev: dpcls per in_port with sorted subtables

2016-07-04 Thread Jarno Rajahalme
I like this RFC patch and suggest you send a non-RFC patch after taking care of the following: - There are numerous coding style violations. I've done my best to note them below, but you should also read 'CodingStyle.md'. - The subject line should have 'Patch' in all upper-case and have the ver