Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0

2015-03-04 Thread Pravin Shelar
On Tue, Feb 17, 2015 at 1:20 PM, Mark Kavanagh wrote: > DPDK v1.8.0 makes significant changes to struct rte_mbuf, including > removal of the 'pkt' and 'data' fields. The latter, formally a > pointer, is now calculated via an offset from the start of the > segment buffer. These fields are reference

Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0

2015-02-24 Thread Pravin Shelar
On Tue, Feb 24, 2015 at 11:29 AM, Kavanagh, Mark B wrote: >> On 02/17/2015 11:20 PM, Mark Kavanagh wrote: >> > DPDK v1.8.0 makes significant changes to struct rte_mbuf, including >> > removal of the 'pkt' and 'data' fields. The latter, formally a >> > pointer, is now calculated via an offset from

Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0

2015-02-24 Thread Kavanagh, Mark B
> On 02/17/2015 11:20 PM, Mark Kavanagh wrote: > > DPDK v1.8.0 makes significant changes to struct rte_mbuf, including > > removal of the 'pkt' and 'data' fields. The latter, formally a > > pointer, is now calculated via an offset from the start of the > > segment buffer. These fields are reference

Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0

2015-02-18 Thread Kavanagh, Mark B
> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Tuesday, February 17, 2015 9:51 PM > To: Kavanagh, Mark B > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0 > > I'll leave the main review here to

Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0

2015-02-17 Thread Panu Matilainen
On 02/17/2015 11:20 PM, Mark Kavanagh wrote: DPDK v1.8.0 makes significant changes to struct rte_mbuf, including removal of the 'pkt' and 'data' fields. The latter, formally a pointer, is now calculated via an offset from the start of the segment buffer. These fields are referenced by OVS when ac

Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0

2015-02-17 Thread Ben Pfaff
I'll leave the main review here to Pravin, but I did notice one thing. There's a comment here that talks about how something changed. That's useful enough to someone who knows how it was before, but it's a little unfriendly to new readers. I prefer comments to talk about the current state of affa