Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-22 Thread Pravin Shelar
Attached is the script. It is also available in kernel source under script directory. Thanks, Pravin. On Tue, Jul 22, 2014 at 5:23 PM, Wenyu Zhang wrote: > May you share checkpatch.pl? I try to look up it in ovs but not find. > > Bests, > Wenyu > -Original Message- > From: Pravin Shelar

Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-22 Thread Wenyu Zhang
May you share checkpatch.pl? I try to look up it in ovs but not find. Bests, Wenyu -Original Message- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Wednesday, July 23, 2014 7:50 AM To: Wenyu Zhang Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org Subject: Re: [PATCH

Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-22 Thread Pravin Shelar
On Tue, Jul 22, 2014 at 4:19 PM, Wenyu Zhang wrote: > Thanks for the checking. > > I will correct them. Do you know any similar script for user space codes? > I don't think there is such script for userspace. ___ dev mailing list dev@openvswitch.org htt

Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-22 Thread Wenyu Zhang
Thanks for the checking. I will correct them. Do you know any similar script for user space codes? Thanks a lot. Wenyu 在 2014-7-23,5:29,"Pravin Shelar" 写道: > I have seen multiple coding style errors and warning from kernel > checkpatch.pl on kernel part of the patch:- > > WARNING: Missing a

Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-22 Thread Wenyu Zhang
My comments inline. 发自我的 iPhone 在 2014-7-23,4:02,"Pravin Shelar" 写道: > On Mon, Jul 21, 2014 at 8:35 PM, Wenyu Zhang wrote: >> Thanks for the review, my comments inline. >> >> Bests, >> Wenyu >> -Original Message- >> From: Pravin Shelar [mailto:pshe...@nicira.com] >> Sent: Tuesday, Jul

Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-22 Thread Pravin Shelar
I have seen multiple coding style errors and warning from kernel checkpatch.pl on kernel part of the patch:- WARNING: Missing a blank line after declarations #88: FILE: datapath/actions.c:530: + struct vport *vport; + vport = ovs_vport_ovsl_rcu(dp, nla_get_u32(a)); ERROR: space required before th

Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-22 Thread Pravin Shelar
On Mon, Jul 21, 2014 at 8:35 PM, Wenyu Zhang wrote: > Thanks for the review, my comments inline. > > Bests, > Wenyu > -Original Message- > From: Pravin Shelar [mailto:pshe...@nicira.com] > Sent: Tuesday, July 22, 2014 6:56 AM > To: Wenyu Zhang > Cc: Romain Lenglet; Ben Pfaff; Jesse Gross;

Re: [ovs-dev] [PATCH v5] Extend OVS IPFIX exporter to export tunnel headers

2014-07-21 Thread Wenyu Zhang
Thanks for the review, my comments inline. Bests, Wenyu -Original Message- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Tuesday, July 22, 2014 6:56 AM To: Wenyu Zhang Cc: Romain Lenglet; Ben Pfaff; Jesse Gross; dev@openvswitch.org Subject: Re: [PATCH v5] Extend OVS IPFIX exporter