Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-18 Thread Loftus, Ciara
> Hi Sean, > > 2016-08-15 9:04 GMT-07:00 Mooney, Sean K : > Hi Daniele > Sorry to top post but I have just read back over the last > couple of revisions of this patch. > > No problem, thanks for stepping in.  As I said many times during the review > of this series I'm not sure what the best inter

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-17 Thread Mooney, Sean K
hi Daniele. Sorry I missed this message but Ciara just pointed this out to me. From: Daniele Di Proietto [mailto:diproiet...@ovn.org] Sent: Monday, August 15, 2016 6:10 PM To: Mooney, Sean K Cc: Loftus, Ciara ; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Daniele Di Proietto
Hi Sean, 2016-08-15 9:04 GMT-07:00 Mooney, Sean K : > Hi Daniele > Sorry to top post but I have just read back over the last > couple of revisions of this patch. > No problem, thanks for stepping in. As I said many times during the review of this series I'm not sure what the best interface woul

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Mooney, Sean K
from this review Regards Sean. > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Saturday, August 13, 2016 1:41 AM > To: Loftus, Ciara > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4 3/3] netd

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Loftus, Ciara
> > Thanks for the patch, I tried it and it makes possible to restart vswitchd and > qemu. > I believe that now vhost_server_id and vhost_client_id are not constant for > the lifetime of the struct and must be protected with dev->mutex. > The following incremental on top of your patch does that an

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-12 Thread Daniele Di Proietto
Thanks for the patch, I tried it and it makes possible to restart vswitchd and qemu. I believe that now vhost_server_id and vhost_client_id are not constant for the lifetime of the struct and must be protected with dev->mutex. The following incremental on top of your patch does that and remove ex