Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: Introduce pmd-rxq-affinity.

2016-07-26 Thread Daniele Di Proietto
Looks mostly good to me, a couple more comments inline Thanks, Daniele On 26/07/2016 06:48, "Ilya Maximets" wrote: >On 26.07.2016 04:46, Daniele Di Proietto wrote: >> Thanks for the patch. >> >> I haven't been able to apply this without the XPS patch. > >That was the original idea. Using of

Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: Introduce pmd-rxq-affinity.

2016-07-26 Thread Ilya Maximets
On 26.07.2016 04:46, Daniele Di Proietto wrote: > Thanks for the patch. > > I haven't been able to apply this without the XPS patch. That was the original idea. Using of this patch with current tx queue management may lead to performance issues on multiqueue configurations. > This looks like a p

Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: Introduce pmd-rxq-affinity.

2016-07-25 Thread Daniele Di Proietto
Thanks for the patch. I haven't been able to apply this without the XPS patch. This looks like a perfect chance to add more tests to pmd.at. I can do it if you want I started taking a look at this patch and I have a few comments inline. I'll keep looking at it tomorrow Thanks, Daniele On