Re: [ovs-dev] [PATCH v3 1/2] lib/util: Add clz() and clz64().

2013-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2013 at 03:15:18PM -0800, Jarno Rajahalme wrote: > > On Nov 21, 2013, at 2:48 PM, Ben Pfaff wrote: > > > On Thu, Nov 21, 2013 at 02:25:30PM -0800, Jarno Rajahalme wrote: > >> Count leading zeroes using builtins if available. > >> > >> Signed-off-by: Jarno Rajahalme > > > > Cou

Re: [ovs-dev] [PATCH v3 1/2] lib/util: Add clz() and clz64().

2013-11-21 Thread Jarno Rajahalme
On Nov 21, 2013, at 2:48 PM, Ben Pfaff wrote: > On Thu, Nov 21, 2013 at 02:25:30PM -0800, Jarno Rajahalme wrote: >> Count leading zeroes using builtins if available. >> >> Signed-off-by: Jarno Rajahalme > > Could we rename raw_clz() to raw_clz64()? clz is a function that > doesn't make sense

Re: [ovs-dev] [PATCH v3 1/2] lib/util: Add clz() and clz64().

2013-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2013 at 02:25:30PM -0800, Jarno Rajahalme wrote: > Count leading zeroes using builtins if available. > > Signed-off-by: Jarno Rajahalme Could we rename raw_clz() to raw_clz64()? clz is a function that doesn't make sense without a defined length. > +static inline int > +raw_clz(