Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-19 Thread Stokes, Ian
; To: Flavio Leitner > > > Cc: dev@openvswitch.org > > > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS > functionality. > > > > > > > On Thu, 11 Feb 2016 12:32:56 + "Stokes, Ian" > > > > wrote: > > > > > &g

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-18 Thread Flavio Leitner
> > > > I'll > > > re-spin a new version also. > > > > > > Thank you for the patch! > > > comments inline. > > > > > > > > > > > > > > > -Original Message----- > > > > > From: Fla

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-17 Thread Stokes, Ian
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Thursday, February 11, 2016 2:42 PM > To: Flavio Leitner > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > &g

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-11 Thread Stokes, Ian
-Original Message- > > > From: Flavio Leitner [mailto:f...@sysclose.org] > > > Sent: Wednesday, February 10, 2016 7:55 PM > > > To: Stokes, Ian > > > Cc: dev@openvswitch.org > > > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS >

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-11 Thread Flavio Leitner
io Leitner [mailto:f...@sysclose.org] > > Sent: Wednesday, February 10, 2016 7:55 PM > > To: Stokes, Ian > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > > > > On Mon, 1 Feb 2016 20:47:25 + > > Ian

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-11 Thread Stokes, Ian
Thanks for the review Daniele, comments inline. Will re-spin another version. > Thanks for the patch and the review. > > I agree with everything Flavio pointed out, a few more comments below > > On 10/02/2016 11:54, "Flavio Leitner" wrote: > > >On Mon, 1 Feb 2016 20:47:25 + > >Ian Stokes

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-11 Thread Stokes, Ian
; Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > > On Mon, 1 Feb 2016 20:47:25 + > Ian Stokes wrote: > > > This patch provides the modifications required in netdev-dpdk.c and > > vswitch.xml to allow for a DPDK user space QoS algorithm. > >

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-10 Thread Daniele Di Proietto
Thanks for the patch and the review. I agree with everything Flavio pointed out, a few more comments below On 10/02/2016 11:54, "Flavio Leitner" wrote: >On Mon, 1 Feb 2016 20:47:25 + >Ian Stokes wrote: > >> This patch provides the modifications required in netdev-dpdk.c and >> vswitch.xml

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-10 Thread Flavio Leitner
On Mon, 1 Feb 2016 20:47:25 + Ian Stokes wrote: > This patch provides the modifications required in netdev-dpdk.c and > vswitch.xml to allow for a DPDK user space QoS algorithm. > > This patch adds a QoS configuration structure for netdev-dpdk and > expected QoS operations 'dpdk_qos_ops'. V

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-08 Thread Stokes, Ian
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, February 05, 2016 9:19 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > > On Thu, Feb 04, 2016 at 09:30:59AM

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-08 Thread Stokes, Ian
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Friday, February 05, 2016 9:45 PM > To: Ben Pfaff; Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > > >

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-05 Thread Daniele Di Proietto
On 05/02/2016 13:18, "Ben Pfaff" wrote: >On Thu, Feb 04, 2016 at 09:30:59AM +, Stokes, Ian wrote: >> Just wondering is there any feedback for the V3 patch below for QoS >>functionality? >> >> This patch has been in and out of review since October, I think I've >>reworked it to meet any spe

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-05 Thread Ben Pfaff
On Thu, Feb 04, 2016 at 09:30:59AM +, Stokes, Ian wrote: > Just wondering is there any feedback for the V3 patch below for QoS > functionality? > > This patch has been in and out of review since October, I think I've reworked > it to meet any specific issues raised. > > If there is anything

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-04 Thread Stokes, Ian
Hi all, Just wondering is there any feedback for the V3 patch below for QoS functionality? This patch has been in and out of review since October, I think I've reworked it to meet any specific issues raised. If there is anything of concern holding it back from being committed I'd really appre