Re: [ovs-dev] [PATCH v3] lib/dpif-netdev: Integrate megaflow classifier.

2014-10-28 Thread Simon Horman
On Tue, Oct 28, 2014 at 02:47:00PM -0700, Alex Wang wrote: > Hey Simon, > > I did the following test: > > - Environment: > >host 1: 7 pmd threads, each pmd thread handling one rx queue from >interface dpdk1 > > >bash-4.3# ovs-appctl dpctl/show >netdev@ovs-netdev: >l

Re: [ovs-dev] [PATCH v3] lib/dpif-netdev: Integrate megaflow classifier.

2014-10-28 Thread Alex Wang
Hey Simon, I did the following test: - Environment: host 1: 7 pmd threads, each pmd thread handling one rx queue from interface dpdk1 bash-4.3# ovs-appctl dpctl/show netdev@ovs-netdev: lookups: hit:778832 missed:3242727 lost:0 flows: 89270 port 1: b

Re: [ovs-dev] [PATCH v3] lib/dpif-netdev: Integrate megaflow classifier.

2014-10-27 Thread Simon Horman
On Thu, Oct 16, 2014 at 02:33:03PM -0700, Jarno Rajahalme wrote: > flow inserts and removals are simplified: > > - No need for classifier internal mutex, as dpif-netdev already has a > 'flow_mutex'. > - Number of memory allocations/frees can be halved. > > Lookup code path is a bit more effcien

Re: [ovs-dev] [PATCH v3] lib/dpif-netdev: Integrate megaflow classifier.

2014-10-17 Thread Jarno Rajahalme
On Oct 16, 2014, at 11:09 PM, Alex Wang wrote: > Thx for the revision, > > > +/* Removes 'rule' from 'cls', also destructing the 'rule'. */ > +static void > +dpcls_remove(struct dpcls *cls, struct dpcls_rule *rule) > +{ > +struct dpcls_subtable *subtable; > + > +ovs_assert(rule->mask);

Re: [ovs-dev] [PATCH v3] lib/dpif-netdev: Integrate megaflow classifier.

2014-10-16 Thread Alex Wang
Thx for the revision, > +/* Removes 'rule' from 'cls', also destructing the 'rule'. */ > +static void > +dpcls_remove(struct dpcls *cls, struct dpcls_rule *rule) > +{ > +struct dpcls_subtable *subtable; > + > +ovs_assert(rule->mask); > + > +INIT_CONTAINER(subtable, rule->mask, mask);