Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

2016-06-14 Thread Nithin Raju
Glad we were able to resolve this :) -Original Message- From: Alin Serdean Date: Tuesday, June 14, 2016 at 9:12 AM To: Nithin Raju , "dev@openvswitch.org" Subject: RE: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum >> >greater than the maximum header size wh

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

2016-06-14 Thread Alin Serdean
> >greater than the maximum header size which is configurable. In the case > >of VXLAN / STT we can be in the case above, because of the UDP/TCP like > >packet > > [Nithin]: Yes, in fact even for NICs that support header-split (mostly Intel), [Alin Gabriel Serdean: ] I looked over some Intel specs

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

2016-06-13 Thread Nithin Raju
>> >>-Mesaj original- >> De la: Nithin Raju [mailto:nit...@vmware.com] >> Trimis: Wednesday, June 8, 2016 10:10 PM >> Către: Alin Serdean ; >> dev@openvswitch.org >> Subiect: Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum >>

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

2016-06-08 Thread Alin Serdean
Thanks for the review answer inlined. Thanks, Alin. > -Mesaj original- > De la: Nithin Raju [mailto:nit...@vmware.com] > Trimis: Wednesday, June 8, 2016 10:10 PM > Către: Alin Serdean ; > dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v3] datapath-windows

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

2016-06-08 Thread Nithin Raju
> #endif >@@ -299,34 +312,21 @@ OvsDecapGre(POVS_SWITCH_CONTEXT switchContext, > EthHdr *ethHdr; > IPHdr *ipHdr; > GREHdr *greHdr; >-UINT32 tunnelSize = 0, packetLength = 0; >+UINT32 tunnelSize, packetLength; > UINT32 headRoom = 0; > PUINT8 bufferStart; > NDIS_STATU