Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-05-11 Thread Simon Horman
On Thu, May 01, 2014 at 09:45:12AM -0700, Jesse Gross wrote: > On Thu, May 1, 2014 at 1:54 AM, Simon Horman wrote: > > On Wed, Apr 30, 2014 at 03:56:44PM -0700, Jesse Gross wrote: > >> On Tue, Apr 29, 2014 at 10:58 PM, Simon Horman wrote: > >> > On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gro

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-05-01 Thread Jesse Gross
On Thu, May 1, 2014 at 1:54 AM, Simon Horman wrote: > On Wed, Apr 30, 2014 at 03:56:44PM -0700, Jesse Gross wrote: >> On Tue, Apr 29, 2014 at 10:58 PM, Simon Horman wrote: >> > On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gross wrote: >> >> On Mon, Apr 28, 2014 at 5:13 PM, Simon Horman wrote:

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-05-01 Thread Simon Horman
On Wed, Apr 30, 2014 at 03:56:44PM -0700, Jesse Gross wrote: > On Tue, Apr 29, 2014 at 10:58 PM, Simon Horman wrote: > > On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gross wrote: > >> On Mon, Apr 28, 2014 at 5:13 PM, Simon Horman wrote: > >> > On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gr

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-30 Thread Jesse Gross
On Tue, Apr 29, 2014 at 10:58 PM, Simon Horman wrote: > On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gross wrote: >> On Mon, Apr 28, 2014 at 5:13 PM, Simon Horman wrote: >> > On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote: >> >> On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrot

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-29 Thread Simon Horman
On Tue, Apr 29, 2014 at 11:41:57AM -0700, Jesse Gross wrote: > On Mon, Apr 28, 2014 at 5:13 PM, Simon Horman wrote: > > On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote: > >> On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote: > >> > On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gr

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-29 Thread Jesse Gross
On Mon, Apr 28, 2014 at 5:13 PM, Simon Horman wrote: > On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote: >> On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote: >> > On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote: >> >> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi >>

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-28 Thread Simon Horman
On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote: > On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote: > > On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote: > >> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi > >> wrote: > >> >> On Thu, Apr 24, 2014 at 05:57:29PM +0900

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-28 Thread Jesse Gross
On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman wrote: > On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote: >> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi >> wrote: >> >> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote: >> >>> hi, >> >>> >> >>> > + * Due to the sam

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-28 Thread Simon Horman
On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote: > On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi > wrote: > >> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote: > >>> hi, > >>> > >>> > + * Due to the sample action there may be multiple possible eth types. > >>> > +

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-27 Thread YAMAMOTO Takashi
> On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi > wrote: >>> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote: hi, > + * Due to the sample action there may be multiple possible eth types. > + * In order to correctly validate actions all possible types are tr

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-25 Thread Jesse Gross
On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi wrote: >> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote: >>> hi, >>> >>> > + * Due to the sample action there may be multiple possible eth types. >>> > + * In order to correctly validate actions all possible types are tracked >>>

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-25 Thread YAMAMOTO Takashi
> On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote: >> hi, >> >> > + * Due to the sample action there may be multiple possible eth types. >> > + * In order to correctly validate actions all possible types are tracked >> > + * and verified. This is done using struct eth_types. >> >

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-24 Thread Simon Horman
On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote: > hi, > > > + * Due to the sample action there may be multiple possible eth types. > > + * In order to correctly validate actions all possible types are tracked > > + * and verified. This is done using struct eth_types. > > is ther

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-24 Thread YAMAMOTO Takashi
hi, > + * Due to the sample action there may be multiple possible eth types. > + * In order to correctly validate actions all possible types are tracked > + * and verified. This is done using struct eth_types. is there any real-world use cases of these actions inside a sample? otherwise, how abou

Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

2014-04-09 Thread Simon Horman
On Tue, Apr 01, 2014 at 12:46:20PM +0900, Simon Horman wrote: > Hi Jesse, Hi Pravin, Hi All, > > This patchset makes use of a whitelist to only allow mpls_push actions to > be applied to packets with an ethertype where the tag order is well defined > and implemented. This avoids the problem of whe