Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-24 Thread Simon Horman
On Wed, Apr 24, 2013 at 10:51:37AM -0700, Jesse Gross wrote: > On Wed, Apr 24, 2013 at 2:12 AM, Simon Horman wrote: > > On Tue, Apr 23, 2013 at 06:47:36PM -0700, Jesse Gross wrote: > >> On Tue, Apr 23, 2013 at 12:58 AM, Simon Horman wrote: > >> > On Tue, Apr 23, 2013 at 07:41:37AM +, Rajahalm

Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-24 Thread Jesse Gross
On Wed, Apr 24, 2013 at 2:12 AM, Simon Horman wrote: > On Tue, Apr 23, 2013 at 06:47:36PM -0700, Jesse Gross wrote: >> On Tue, Apr 23, 2013 at 12:58 AM, Simon Horman wrote: >> > On Tue, Apr 23, 2013 at 07:41:37AM +, Rajahalme, Jarno (NSN - >> > FI/Espoo) wrote: >> >> >> >> On Apr 23, 2013, a

Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-24 Thread Simon Horman
On Tue, Apr 23, 2013 at 06:47:36PM -0700, Jesse Gross wrote: > On Tue, Apr 23, 2013 at 12:58 AM, Simon Horman wrote: > > On Tue, Apr 23, 2013 at 07:41:37AM +, Rajahalme, Jarno (NSN - FI/Espoo) > > wrote: > >> > >> On Apr 23, 2013, at 4:51 , ext Simon Horman wrote: > >> > >> > On Mon, Apr 22,

Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-23 Thread Jesse Gross
On Tue, Apr 23, 2013 at 12:58 AM, Simon Horman wrote: > On Tue, Apr 23, 2013 at 07:41:37AM +, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> On Apr 23, 2013, at 4:51 , ext Simon Horman wrote: >> >> > On Mon, Apr 22, 2013 at 01:55:43PM +, Rajahalme, Jarno (NSN - >> > FI/Espoo) wrote: >>

Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-23 Thread Simon Horman
On Tue, Apr 23, 2013 at 07:41:37AM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Apr 23, 2013, at 4:51 , ext Simon Horman wrote: > > > On Mon, Apr 22, 2013 at 01:55:43PM +, Rajahalme, Jarno (NSN - FI/Espoo) > > wrote: > >> > >> Here the skb_network_header is changed to point to th

Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-23 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Apr 23, 2013, at 4:51 , ext Simon Horman wrote: > On Mon, Apr 22, 2013 at 01:55:43PM +, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> Here the skb_network_header is changed to point to the L3 header. Is it >> significant that in some cases (?) mpls_stack_depth may remain at zero, >> e

Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-22 Thread Simon Horman
On Mon, Apr 22, 2013 at 01:55:43PM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > On Apr 22, 2013, at 5:12 , ext Simon Horman wrote: > > > diff --git a/datapath/actions.c b/datapath/actions.c > ... > > +static int push_mpls(struct sk_buff *skb, > > +const struct ovs_action_push

Re: [ovs-dev] [PATCH v2.26] datapath: Add basic MPLS support to kernel

2013-04-22 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Apr 22, 2013, at 5:12 , ext Simon Horman wrote: > diff --git a/datapath/actions.c b/datapath/actions.c ... > +static int push_mpls(struct sk_buff *skb, > + const struct ovs_action_push_mpls *mpls, > + unsigned *mpls_stack_depth) > +{ > + __be32 *new_mpls_ls