Re: [ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

2014-08-08 Thread Jesse Gross
On Fri, Aug 8, 2014 at 1:28 PM, Jarno Rajahalme wrote: > On Aug 5, 2014, at 10:57 AM, Jesse Gross wrote: > >> On Fri, Jul 18, 2014 at 8:15 AM, Jarno Rajahalme >> wrote: >>> On May 8, 2014, at 1:27 PM, Jesse Gross wrote: >> One difficulty that comes to mind is that for tunnel operations we >> j

Re: [ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

2014-08-08 Thread Jarno Rajahalme
I’ve just posted a v3 of this series, Jarno On Aug 5, 2014, at 10:57 AM, Jesse Gross wrote: > On Fri, Jul 18, 2014 at 8:15 AM, Jarno Rajahalme > wrote: >> On May 8, 2014, at 1:27 PM, Jesse Gross wrote: >> >>> On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme >>> wrote: Masked set ac

Re: [ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

2014-08-05 Thread Jesse Gross
On Fri, Jul 18, 2014 at 8:15 AM, Jarno Rajahalme wrote: > On May 8, 2014, at 1:27 PM, Jesse Gross wrote: > >> On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme >> wrote: >>> Masked set action allows more megaflow wildcarding. Masked set action >>> is now supported for all writeable key types, e

Re: [ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

2014-07-18 Thread Jarno Rajahalme
Jesse, Thanks for the review, and sorry for the time it has taken me to get back to this! Responses below, Jarno On May 8, 2014, at 1:27 PM, Jesse Gross wrote: > On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme > wrote: >> Masked set action allows more megaflow wildcarding. Masked set ac

Re: [ovs-dev] [PATCH v2 8/8] datapath: Allow masks for set actions.

2014-05-08 Thread Jesse Gross
On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme wrote: > Masked set action allows more megaflow wildcarding. Masked set action > is now supported for all writeable key types, except for the tunnel > key. The logic for the tunnel restriction is that it is always cleared at the start of the pipel