Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-11 Thread Loftus, Ciara
> > > 2016-08-08 7:18 GMT-07:00 Loftus, Ciara : > > > > The patch mostly looks good to me, thanks. > > I'm not 100% sure about the interface.  Can we make the flag interface > > specific? > > I'm not 100% sure about making the flag interface specific :) Do you think > there's a use case for both

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-09 Thread Daniele Di Proietto
2016-08-08 7:18 GMT-07:00 Loftus, Ciara : > > > > The patch mostly looks good to me, thanks. > > I'm not 100% sure about the interface. Can we make the flag interface > > specific? > > I'm not 100% sure about making the flag interface specific :) Do you think > there's a use case for both client

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-08 Thread Loftus, Ciara
> > The patch mostly looks good to me, thanks. > I'm not 100% sure about the interface.  Can we make the flag interface > specific? I'm not 100% sure about making the flag interface specific :) Do you think there's a use case for both client and server mode ports to be used in conjunction with

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-05 Thread Daniele Di Proietto
The patch mostly looks good to me, thanks. I'm not 100% sure about the interface. Can we make the flag interface specific? If I'm not mistaken we currently limit vhost-sock-dir to be under OVS rundir. With client mode this is not necessary anymore. I hope that client will be made the default m