On 08/03/2015 07:53 PM, Russell Bryant wrote:
> On 08/03/2015 07:47 PM, Ben Pfaff wrote:
>> On Mon, Aug 03, 2015 at 07:44:03PM -0400, Russell Bryant wrote:
>>> On 08/03/2015 07:42 PM, Ben Pfaff wrote:
Thank you for such a careful review!
I incorporated all of these comments and appli
On Mon, Aug 03, 2015 at 07:53:58PM -0400, Russell Bryant wrote:
> On 08/03/2015 07:47 PM, Ben Pfaff wrote:
> > On Mon, Aug 03, 2015 at 07:44:03PM -0400, Russell Bryant wrote:
> >> On 08/03/2015 07:42 PM, Ben Pfaff wrote:
> >>> Thank you for such a careful review!
> >>>
> >>> I incorporated all of t
On 08/03/2015 07:47 PM, Ben Pfaff wrote:
> On Mon, Aug 03, 2015 at 07:44:03PM -0400, Russell Bryant wrote:
>> On 08/03/2015 07:42 PM, Ben Pfaff wrote:
>>> Thank you for such a careful review!
>>>
>>> I incorporated all of these comments and applied this to master.
>>
>> Awesome work, Ben!
>
> Than
On Mon, Aug 03, 2015 at 07:44:03PM -0400, Russell Bryant wrote:
> On 08/03/2015 07:42 PM, Ben Pfaff wrote:
> > Thank you for such a careful review!
> >
> > I incorporated all of these comments and applied this to master.
>
> Awesome work, Ben!
Thanks. It really needs testing, though--I haven't
On 08/03/2015 07:42 PM, Ben Pfaff wrote:
> Thank you for such a careful review!
>
> I incorporated all of these comments and applied this to master.
Awesome work, Ben!
--
Russell Bryant
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
Thank you for such a careful review!
I incorporated all of these comments and applied this to master. Here's
the incremental (it omits the changes to this patch due to changes in
earlier patches, e.g. the Rule->Logical_Flow renaming):
diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c
I applied most of your comments as obvious. A few deserved responses,
see below.
On Mon, Aug 03, 2015 at 01:19:01AM -0700, Justin Pettit wrote:
>
> > On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
> > +/* Translate logical table ID to physical table ID. */
> > +bool ingress = !st
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
I missed this in my review yesterday on ovn-architure.7.xml:
> +OpenFlow tables 32 through 47 implement the output
> action
> +in the the logical ingress pipeline. Specifically, table 32 handles
This introduces two "the"s.
J
> On Jul 28, 2015, at 8:44 AM, Ben Pfaff wrote:
>
Thanks, Ben. This is a great patch. I still owe you a review on the function
physical_run(), but it's fairly complicated, and my reviewing powers are
rapidly weakening. I'll finish the review in the morning, but wanted to give
you some ear
