Re: [ovs-dev] [PATCH v2 1/7] lib: Fix compose nd

2016-03-23 Thread pravin shelar
On Wed, Mar 23, 2016 at 3:09 PM, Ben Pfaff wrote: > On Wed, Mar 23, 2016 at 02:57:10PM -0700, pravin shelar wrote: >> On Wed, Mar 23, 2016 at 8:20 AM, Ben Pfaff wrote: >> > On Tue, Mar 15, 2016 at 09:57:27AM -0700, Pravin B Shelar wrote: >> >> Following patch fixes number of issues with compose n

Re: [ovs-dev] [PATCH v2 1/7] lib: Fix compose nd

2016-03-23 Thread Ben Pfaff
On Wed, Mar 23, 2016 at 02:57:10PM -0700, pravin shelar wrote: > On Wed, Mar 23, 2016 at 8:20 AM, Ben Pfaff wrote: > > On Tue, Mar 15, 2016 at 09:57:27AM -0700, Pravin B Shelar wrote: > >> Following patch fixes number of issues with compose nd, like > >> setting ip packet header, set ICMP opt-len,

Re: [ovs-dev] [PATCH v2 1/7] lib: Fix compose nd

2016-03-23 Thread pravin shelar
On Wed, Mar 23, 2016 at 8:20 AM, Ben Pfaff wrote: > On Tue, Mar 15, 2016 at 09:57:27AM -0700, Pravin B Shelar wrote: >> Following patch fixes number of issues with compose nd, like >> setting ip packet header, set ICMP opt-len, checksum. >> >> Signed-off-by: Pravin B Shelar > > I didn't test this

Re: [ovs-dev] [PATCH v2 1/7] lib: Fix compose nd

2016-03-23 Thread Ben Pfaff
On Tue, Mar 15, 2016 at 09:57:27AM -0700, Pravin B Shelar wrote: > Following patch fixes number of issues with compose nd, like > setting ip packet header, set ICMP opt-len, checksum. > > Signed-off-by: Pravin B Shelar I didn't test this; presumably some later patch will exercise it? Acked-by: