Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Rework of rx queue management.

2016-01-25 Thread Ilya Maximets
On 26.01.2016 03:21, Daniele Di Proietto wrote: > Hi, > > On 25/01/2016 04:00, "Ilya Maximets" wrote: > >> Thank you. >> Comments inline. >> >> On 23.01.2016 04:21, Daniele Di Proietto wrote: >>> Hi Ilya, >>> >>> Thank you very much for the patch. >>> >>> I definitely like that the queue assignm

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Rework of rx queue management.

2016-01-25 Thread Daniele Di Proietto
Hi, On 25/01/2016 04:00, "Ilya Maximets" wrote: >Thank you. >Comments inline. > >On 23.01.2016 04:21, Daniele Di Proietto wrote: >> Hi Ilya, >> >> Thank you very much for the patch. >> >> I definitely like that the queue assignment is performed by the >> main thread: not only is less bug-prone

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Rework of rx queue management.

2016-01-25 Thread Ilya Maximets
Thank you. Comments inline. On 23.01.2016 04:21, Daniele Di Proietto wrote: > Hi Ilya, > > Thank you very much for the patch. > > I definitely like that the queue assignment is performed by the > main thread: not only is less bug-prone, but the logic will be more > easily customizable. > > I ab

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Rework of rx queue management.

2016-01-22 Thread Daniele Di Proietto
Hi Ilya, Thank you very much for the patch. I definitely like that the queue assignment is performed by the main thread: not only is less bug-prone, but the logic will be more easily customizable. I absolutely welcome the changes to do_add_port and do_del_port to keep the queues to the currently