Re: [ovs-dev] [PATCH v2] lib/netdev-windows.c: nuke the init function

2014-10-08 Thread Nithin Raju
On Oct 8, 2014, at 8:27 AM, Ben Pfaff wrote: > You should specify a return type, e.g. "int". > > Thanks, > > Ben. Thanks for the review. Respin (v3) will be up in a bit. Thanks, -- Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.

Re: [ovs-dev] [PATCH v2] lib/netdev-windows.c: nuke the init function

2014-10-08 Thread Ben Pfaff
On Tue, Oct 07, 2014 at 05:21:04PM -0700, Nithin Raju wrote: > The init function is not allowed to call into the kernel datapath > while running unit tests since the kernel datapath is not loaded. > Instead of making the function dummy, it is better to not have it > at all. > > Signed-off-by: Nith