] [PATCH v2] datapath-windows: accommodate to UFID changes
On 4 February 2015 at 16:31, Ankur Sharma wrote:
>
> @@ -103,7 +103,9 @@ const NL_POLICY nlFlowPolicy[] = {
> .maxLen = sizeof(struct ovs_flow_stats),
> .opt
On 4 February 2015 at 16:31, Ankur Sharma wrote:
>
> @@ -103,7 +103,9 @@ const NL_POLICY nlFlowPolicy[] = {
> .maxLen = sizeof(struct ovs_flow_stats),
> .optional = TRUE},
> [OVS_FLOW_ATTR_TCP_FLAGS] = {NL_A_U8, .optional = TRUE},
>
Hey Alin,
Thanks for the patch.
Please find my comments inline.
I have not worked on this code for sometime, so may miss something here.
Can you please also let us know the unit testing that you did? Although change
is minor, but editing FLOW_KEY* related code may end up breaking some
function
hi Alin,
Thanks for the patch.
From my reading, it seems that you are attempting to add support in the kernel
datapath to not handle the UFID attribute gracefully, even though there’s no
support for it in the kernel datapath. It would be useful to add a comment in
the code to this effect that U
