Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-16 Thread Ben Pfaff
On Tue, Jun 16, 2015 at 12:38:06PM -0300, Thadeu Lima de Souza Cascardo wrote: > On Tue, Jun 16, 2015 at 08:16:33AM -0700, Ben Pfaff wrote: > > On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > > > Support IGMPv3 messages with multiple records. Make sure all IGMP

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-16 Thread Thadeu Lima de Souza Cascardo
On Tue, Jun 16, 2015 at 08:16:33AM -0700, Ben Pfaff wrote: > On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Support IGMPv3 messages with multiple records. Make sure all IGMPv3 > > messages go through slow path, since they may carry multiple multicast > > addresse

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-16 Thread Ben Pfaff
On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo wrote: > Support IGMPv3 messages with multiple records. Make sure all IGMPv3 > messages go through slow path, since they may carry multiple multicast > addresses, unlike IGMPv2. > > Tests done: > > * multiple addresses in IGM

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-11 Thread Thadeu Lima de Souza Cascardo
On Thu, Jun 11, 2015 at 12:41:42AM -0300, Flavio Leitner wrote: > > > > + > > > > +offset = p->l4_ofs; > > > > > > The above could be like this: > > > offset = dp_packet_l4(p) - dp_packet_data(p) > > > to avoid accessing internals of dp_packet. > > > > > > > That's how it originally was writ

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-10 Thread Flavio Leitner
On Tue, Jun 09, 2015 at 06:19:35PM -0300, Thadeu Lima de Souza Cascardo wrote: > On Tue, Jun 09, 2015 at 03:03:03PM -0300, Flavio Leitner wrote: > > On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > > > Support IGMPv3 messages with multiple records. Make sure all

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-09 Thread Thadeu Lima de Souza Cascardo
On Tue, Jun 09, 2015 at 03:03:03PM -0300, Flavio Leitner wrote: > On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Support IGMPv3 messages with multiple records. Make sure all IGMPv3 > > messages go through slow path, since they may carry multiple multicast > > add

Re: [ovs-dev] [PATCH v2] IGMPv3 support

2015-06-09 Thread Flavio Leitner
On Mon, Jun 08, 2015 at 01:05:41PM -0300, Thadeu Lima de Souza Cascardo wrote: > Support IGMPv3 messages with multiple records. Make sure all IGMPv3 > messages go through slow path, since they may carry multiple multicast > addresses, unlike IGMPv2. > > Tests done: > > * multiple addresses in IGM