Re: [ovs-dev] [PATCH v2] : ovn-controller - Assign zone-ids consistently

2016-02-11 Thread Justin Pettit
> On Feb 10, 2016, at 12:14 PM, Russell Bryant wrote: > >> @@ -112,10 +171,8 @@ update_ct_zones(struct sset *lports, struct simap >> *ct_zones, >> bitmap_set1(ct_zone_bitmap, zone); >> simap_put(ct_zones, iface_id, zone); >> >> -/* xxx We should erase any old entries fo

Re: [ovs-dev] [PATCH v2] : ovn-controller - Assign zone-ids consistently

2016-02-10 Thread Russell Bryant
The subject has an unexpected leading ":". That should probably be removed. I'd then replace " - " with ": " to more closely follow convention. I get several whitespace errors when applying this patch: Applying: ovn-controller - Assign zone-ids consistently /home/rbryant/src/ovs/.git/rebase-app

Re: [ovs-dev] [PATCH v2] : ovn-controller - Assign zone-ids consistently

2016-02-09 Thread Ben Pfaff
On Wed, Feb 10, 2016 at 01:46:24AM +, Suryanarayan Ramamurthy wrote: > Currently, conntrack zone-id is assigned to lport by ovn-controller, > but the ovn-controller does not record this map (lport->zoneid) > > So, after ovn-controller restart, zone-ids may get set > inconsisten