>
>> >> >
>> >> >Hi,
>> >> >
>> >> >Some comments below.
>> >> >
>> >>
>> >> Hi Flavio,
>> >>
>> >> Thanks for your review!
>> >>
>> >> I've responded to your comments inline - I've also addressed the
>> >> cosmetic changes that you suggested in V3 of the patch.
>> >>
>> >> Thanks again,
>> >> Mark
On Fri, 12 Feb 2016 14:36:14 +
"Kavanagh, Mark B" wrote:
> >> >
> >> >Hi,
> >> >
> >> >Some comments below.
> >> >
> >>
> >> Hi Flavio,
> >>
> >> Thanks for your review!
> >>
> >> I've responded to your comments inline - I've also addressed the
> >> cosmetic changes that you suggested in V3 o
>> >
>> >Hi,
>> >
>> >Some comments below.
>> >
>>
>> Hi Flavio,
>>
>> Thanks for your review!
>>
>> I've responded to your comments inline - I've also addressed the
>> cosmetic changes that you suggested in V3 of the patch.
>>
>> Thanks again,
>> Mark
>>
>> >
>> >On Mon, 1 Feb 2016 10:18:54 +
On Mon, 8 Feb 2016 10:54:08 +
"Kavanagh, Mark B" wrote:
> >
> >Hi,
> >
> >Some comments below.
> >
>
> Hi Flavio,
>
> Thanks for your review!
>
> I've responded to your comments inline - I've also addressed the
> cosmetic changes that you suggested in V3 of the patch.
>
> Thanks again,
On Thu, 11 Feb 2016 02:55:43 +
Daniele Di Proietto wrote:
> On 08/02/2016 03:23, "Kavanagh, Mark B" wrote:
>
> >>
> >>Hi Mark,
> >>
> >
> >Hi Daniele,
> >
> >Thanks for the review! Responses inline below.
> >
> >Cheers,
> >Mark
> >
> >>This patch besides adding Jumbo Frame support also
>
>
>On 08/02/2016 03:23, "Kavanagh, Mark B" wrote:
>
>>>
>>>Hi Mark,
>>>
>>
>>Hi Daniele,
>>
>>Thanks for the review! Responses inline below.
>>
>>Cheers,
>>Mark
>>
>>>This patch besides adding Jumbo Frame support also cleans up
>>>the mbuf initialization (by changing the macros, adding
>>>dpdk_b
On 08/02/2016 03:23, "Kavanagh, Mark B" wrote:
>>
>>Hi Mark,
>>
>
>Hi Daniele,
>
>Thanks for the review! Responses inline below.
>
>Cheers,
>Mark
>
>>This patch besides adding Jumbo Frame support also cleans up
>>the mbuf initialization (by changing the macros, adding
>>dpdk_buf_size, and rewri
>
>Hi Mark,
>
Hi Daniele,
Thanks for the review! Responses inline below.
Cheers,
Mark
>This patch besides adding Jumbo Frame support also cleans up
>the mbuf initialization (by changing the macros, adding
>dpdk_buf_size, and rewriting __ovs_rte_pktmbuf_init), so thanks
>for this. I think it ma
>
>Hi,
>
>Some comments below.
>
Hi Flavio,
Thanks for your review!
I've responded to your comments inline - I've also addressed the cosmetic
changes that you suggested in V3 of the patch.
Thanks again,
Mark
>
>On Mon, 1 Feb 2016 10:18:54 +
>Mark Kavanagh wrote:
>
>> Add support for Ju
Hi Mark,
This patch besides adding Jumbo Frame support also cleans up
the mbuf initialization (by changing the macros, adding
dpdk_buf_size, and rewriting __ovs_rte_pktmbuf_init), so thanks
for this. I think it makes sense to split the patch in two:
one that does the clenup, and one that allows c
Some minor comments just in case you decide to spin another version:
On Mon, 1 Feb 2016 10:18:54 +
Mark Kavanagh wrote:
[...]
> +static uint32_t
> +dpdk_buf_size(struct netdev_dpdk *netdev, int frame_len)
> +{
> +struct rte_eth_dev_info info;
> +uint32_t buf_size;
> +/* XXX: T
Hi,
Some comments below.
On Mon, 1 Feb 2016 10:18:54 +
Mark Kavanagh wrote:
> Add support for Jumbo Frames to DPDK-enabled port types,
> using single-segment-mbufs.
>
> Using this approach, the amount of memory allocated for each mbuf
> to store frame data is increased to a value greate
Hi Zoltan. Thanks for your mail - responses inline below.
Cheers,
Mark
>
>Hi,
>
>I have a related question: is it a possible alternative with the current
>codebase to use KNI for configuring the MTU?
This would (as far as I'm aware) require the implementation of a new KNI netdev
class, along wi
Hi,
I have a related question: is it a possible alternative with the current
codebase to use KNI for configuring the MTU?
I never actually tried KNI, does it have a performance penalty to just
have it?
The reason I'm asking these questions because OVS normally doesn't
configure the MTU, but it
14 matches
Mail list logo
