Re: [ovs-dev] [PATCH RFC] configure: make name openvswitch_mod configurable

2012-03-02 Thread Chris Wright
* Ansis Atteka (aatt...@nicira.com) wrote: > On Thu, Mar 1, 2012 at 9:28 PM, Chris Wright wrote: > > insert_openvswitch_mod_if_required () { > > -# If openvswitch_mod is already loaded then we're done. > > -test -e /sys/module/openvswitch_mod && return 0 > > +# If @OVSKMOD@ is already

Re: [ovs-dev] [PATCH RFC] configure: make name openvswitch_mod configurable

2012-03-02 Thread Ansis Atteka
On Thu, Mar 1, 2012 at 9:28 PM, Chris Wright wrote: > This is just an RFC, partly because it ignores datapath/ so you could > build a module that the runtime can't install. Now that the ovs datapath > is upstream and named simply openvswitch, tools like ovs-ctl fail to > function w/ the native d

Re: [ovs-dev] [PATCH RFC] configure: make name openvswitch_mod configurable

2012-03-02 Thread Chris Wright
* Ben Pfaff (b...@nicira.com) wrote: > On Fri, Mar 02, 2012 at 11:31:44AM -0800, Chris Wright wrote: > > * Ben Pfaff (b...@nicira.com) wrote: > > > I wonder whether we should just drop the "_mod" from our out-of-tree > > > module names. Seems simpler and less confusing in the long run. > > > > >

Re: [ovs-dev] [PATCH RFC] configure: make name openvswitch_mod configurable

2012-03-02 Thread Ben Pfaff
On Fri, Mar 02, 2012 at 11:31:44AM -0800, Chris Wright wrote: > * Ben Pfaff (b...@nicira.com) wrote: > > On Thu, Mar 01, 2012 at 09:28:50PM -0800, Chris Wright wrote: > > > This is just an RFC, partly because it ignores datapath/ so you could > > > build a module that the runtime can't install. No

Re: [ovs-dev] [PATCH RFC] configure: make name openvswitch_mod configurable

2012-03-02 Thread Chris Wright
* Ben Pfaff (b...@nicira.com) wrote: > On Thu, Mar 01, 2012 at 09:28:50PM -0800, Chris Wright wrote: > > This is just an RFC, partly because it ignores datapath/ so you could > > build a module that the runtime can't install. Now that the ovs datapath > > is upstream and named simply openvswitch,

Re: [ovs-dev] [PATCH RFC] configure: make name openvswitch_mod configurable

2012-03-02 Thread Ben Pfaff
On Thu, Mar 01, 2012 at 09:28:50PM -0800, Chris Wright wrote: > This is just an RFC, partly because it ignores datapath/ so you could > build a module that the runtime can't install. Now that the ovs datapath > is upstream and named simply openvswitch, tools like ovs-ctl fail to > function w/ the