> On Sep 11, 2015, at 5:02 PM, Joe Stringer wrote:
>
> On 11 September 2015 at 16:37, Jarno Rajahalme wrote:
>> Here is an provisional ACK, I trust you to address the comments to my
>> satisfaction :-)
>>
>> Acked-by: Jarno Rajahalme
>>
>> Jarno
>
> Thanks, but I may yet send a round 2; t
On 11 September 2015 at 16:37, Jarno Rajahalme wrote:
> Here is an provisional ACK, I trust you to address the comments to my
> satisfaction :-)
>
> Acked-by: Jarno Rajahalme
>
> Jarno
Thanks, but I may yet send a round 2; there's a lot of scattered
changes, so I wouldn't mind getting some ex
Conditional to Ben’s approval of the nested actions within the OF ct action, of
course :-)
Jarno
> On Sep 11, 2015, at 4:37 PM, Jarno Rajahalme wrote:
>
> Here is an provisional ACK, I trust you to address the comments to my
> satisfaction :-)
>
> Acked-by: Jarno Rajahalme
>
> Jarno
>
Here is an provisional ACK, I trust you to address the comments to my
satisfaction :-)
Acked-by: Jarno Rajahalme
Jarno
> On Sep 11, 2015, at 4:15 PM, Joe Stringer wrote:
>
> On 11 September 2015 at 14:42, Jarno Rajahalme wrote:
>>> diff --git a/tests/system-traffic.at b/tests/system-traff
On 11 September 2015 at 14:42, Jarno Rajahalme wrote:
>> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
>> index 7dbed68..de6b016 100644
>> --- a/tests/system-traffic.at
>> +++ b/tests/system-traffic.at
>> @@ -139,3 +139,472 @@ NS_CHECK_EXEC([at_ns0], [ping -s 3200 -q -c 3 -i 0.3
On 11 September 2015 at 14:02, Jarno Rajahalme wrote:
>>> - new and reply are mutually exclusive (reply direction is defined as
>>> opposite of the initial +new)
>>
>> Strictly speaking I don't think this is the case. I don't have an
>> example, but it is possible for this to be set in the conntr
Joe,
Below some comments on the tests,
Jarno
> --- a/tests/atlocal.in
> +++ b/tests/atlocal.in
> @@ -110,3 +110,10 @@ fi
> if test "$IS_WIN32" = "yes"; then
> HAVE_PYTHON="no"
> fi
> +
> +# Conntrack test requirements
> +if test x`which conntrack` != x; then
> +HAVE_CONNTRACK="yes"
> +
> On Sep 11, 2015, at 1:07 PM, Joe Stringer wrote:
>
> On 10 September 2015 at 19:03, Jarno Rajahalme wrote:
>>
>>> On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote:
>>> @@ -672,6 +705,8 @@ struct ovs_action_push_tnl {
>>> * indicate the new packet contents. This could potentially still be
>>>
On 10 September 2015 at 11:05, Ben Pfaff wrote:
> Who do you think should review this?
Jarno and I discussed the OpenFlow interface a little at lunch, would
you mind looking at this particular aspect from an API cleanliness
point of view?
___
dev mailin
On 10 September 2015 at 19:03, Jarno Rajahalme wrote:
>
>> On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote:
>> @@ -672,6 +705,8 @@ struct ovs_action_push_tnl {
>> * indicate the new packet contents. This could potentially still be
>> * %ETH_P_MPLS if the resulting MPLS label stack is not empty.
> On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote:
>
>
(snip)
> diff --git a/datapath/linux/compat/include/linux/openvswitch.h
> b/datapath/linux/compat/include/linux/openvswitch.h
> index 578cd88..69bdf32 100644
> --- a/datapath/linux/compat/include/linux/openvswitch.h
> +++ b/datapath/linux
> On Sep 10, 2015, at 3:23 PM, Joe Stringer wrote:
>
> On 10 September 2015 at 11:05, Ben Pfaff wrote:
>> Who do you think should review this?
>
> I think that either Justin or Jarno should probably review this.
I’ll review these, but Justin can chime in as well :-)
Jarno
On 10 September 2015 at 11:05, Ben Pfaff wrote:
> Who do you think should review this?
I think that either Justin or Jarno should probably review this.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Who do you think should review this?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
14 matches
Mail list logo
