On Jun 3, 2014, at 6:05 PM, Ethan Jackson wrote:
> Couple of questions.
>
> First, this patch adds a bit of code which extends beyond 79 characters.
>
Sorry, fixed those.
> dp_netdev_input() does this rather interesting stuff with two keys
> that mfk switches between. This is definitely not
Oh, also I'm getting these errors when compiling with clang's thread
saftey analysis.
../lib/dpif-netdev.c:2115:12: error: reading variable 'head' requires
locking any mutex [-Werror,-Wthread-safety-analysis]
if (q->head - q->tail < MAX_QUEUE_LEN) {
^
../lib/dpif-netdev.c:2115:22: e
Couple of questions.
First, this patch adds a bit of code which extends beyond 79 characters.
dp_netdev_input() does this rather interesting stuff with two keys
that mfk switches between. This is definitely not obvious when first
looking at it. Minimally it needs a comment explaining why. That
