Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-06 Thread Pravin Shelar
On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote: > Upstream commit: > openvswitch: Support VXLAN Group Policy extension > > Introduces support for the group policy extension to the VXLAN virtual > port. The extension is disabled by default and only enabled if the user > has provi

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-06 Thread Jesse Gross
On Fri, Feb 6, 2015 at 3:09 AM, Thomas Graf wrote: > On 02/05/15 at 07:53pm, Pravin Shelar wrote: >> On Thu, Feb 5, 2015 at 6:11 PM, Jesse Gross wrote: >> > We should also think about how to apply this in a consistent manner to >> > other protocols that don't have this issue like Geneve. > > As a

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-06 Thread Thomas Graf
On 02/05/15 at 07:53pm, Pravin Shelar wrote: > On Thu, Feb 5, 2015 at 6:11 PM, Jesse Gross wrote: > > On Thu, Feb 5, 2015 at 6:02 PM, Pravin Shelar wrote: > >> Since it should be possible to configure vxlan tunnel with only > >> REMCSUM_RX or only REMCSUM_TX, I do not think we can store REMCSUM_T

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Pravin Shelar
On Thu, Feb 5, 2015 at 6:11 PM, Jesse Gross wrote: > On Thu, Feb 5, 2015 at 6:02 PM, Pravin Shelar wrote: >> On Thu, Feb 5, 2015 at 1:47 PM, Thomas Graf wrote: >>> On 02/05/15 at 11:58am, Pravin Shelar wrote: On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote: > I kept it because

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Jesse Gross
On Thu, Feb 5, 2015 at 6:02 PM, Pravin Shelar wrote: > On Thu, Feb 5, 2015 at 1:47 PM, Thomas Graf wrote: >> On 02/05/15 at 11:58am, Pravin Shelar wrote: >>> On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote: >>> > I kept it because vxlan_sock only holds the receive side flags only >>> > as mask

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Pravin Shelar
On Thu, Feb 5, 2015 at 1:47 PM, Thomas Graf wrote: > On 02/05/15 at 11:58am, Pravin Shelar wrote: >> On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote: >> > I kept it because vxlan_sock only holds the receive side flags only >> > as masked with VXLAN_F_RCV_FLAGS. GBP is not split into a receive a

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Thomas Graf
On 02/05/15 at 11:58am, Pravin Shelar wrote: > On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote: > > I kept it because vxlan_sock only holds the receive side flags only > > as masked with VXLAN_F_RCV_FLAGS. GBP is not split into a receive and > > transmit flag so your suggestion would work for GB

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Pravin Shelar
On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote: > On 02/04/15 at 03:17pm, Pravin Shelar wrote: >> On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote: >> > + >> > + flags = TUNNEL_KEY; >> > + vxlan_port = vxlan_vport(vport); >> > + if (vxlan_port->exts & VXLAN_F_GBP && md->gbp)

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-05 Thread Thomas Graf
On 02/04/15 at 03:17pm, Pravin Shelar wrote: > On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote: > > + > > + flags = TUNNEL_KEY; > > + vxlan_port = vxlan_vport(vport); > > + if (vxlan_port->exts & VXLAN_F_GBP && md->gbp) > > + flags |= TUNNEL_VXLAN_OPT; > > > why n

Re: [ovs-dev] [PATCH 2/6] datapath: Support VXLAN Group Policy extension

2015-02-04 Thread Pravin Shelar
On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote: > Upstream commit: > openvswitch: Support VXLAN Group Policy extension > > Introduces support for the group policy extension to the VXLAN virtual > port. The extension is disabled by default and only enabled if the user > has provi