Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Ben Pfaff
On Fri, Jan 23, 2015 at 01:17:36AM +, Dave Tucker wrote: > Signed-off-by: Dave Tucker > -#ifndef _WIN32 > +#if !defined(__APPLE__) && !defined(_WIN32) > static inline ovs_be64 > htonll(uint64_t n) It's probably time to add an autoconf test for htonll() instead of using OS-specific tests.

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Thomas Graf
On 01/23/15 at 04:07pm, Dave Tucker wrote: > >This needs some style changes ;-) > > Wait, you mean its obvious I'm not a C coder? > Will take a look and see what I can do... Have a look at CodingStyle.md ;-) ___ dev mailing list dev@openvswitch.org http

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Dave Tucker
On 23 Jan 2015, at 11:37, Thomas Graf wrote: On 01/23/15 at 01:17am, Dave Tucker wrote: diff --git a/lib/socket-util.c b/lib/socket-util.c index 8949da7..732fd89 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -112,6 +112,11 @@ set_dscp(int fd, uint8_t dscp) return 0; #endif +#if

Re: [ovs-dev] [PATCH 2/4] lib: Add Mac OSX compatability

2015-01-23 Thread Thomas Graf
On 01/23/15 at 01:17am, Dave Tucker wrote: > diff --git a/lib/socket-util.c b/lib/socket-util.c > index 8949da7..732fd89 100644 > --- a/lib/socket-util.c > +++ b/lib/socket-util.c > @@ -112,6 +112,11 @@ set_dscp(int fd, uint8_t dscp) > return 0; > #endif > > +#ifdef __APPLE__ > +/* ToDo