Re: [ovs-dev] [PATCH 2/2] poll-loop: Remove static variable n_waiters.

2011-08-15 Thread Ben Pfaff
I have a story there. I had a whole "counted list" implementation ready to go, and then when I went through the tree to find potential users I found only two. And then when I looked closer I found that they didn't really need to count. And that's why there's this patch series that makes them not

Re: [ovs-dev] [PATCH 2/2] poll-loop: Remove static variable n_waiters.

2011-08-15 Thread Justin Pettit
Okay, sounds good. It's not large enough that it makes sense to make the lists counting or anything. --Justin On Aug 15, 2011, at 9:03 AM, Ben Pfaff wrote: > When I occasionally look, I usually see about a dozen or so. Not > enough to concern me, anyway. Some are probably duplicates (same f

Re: [ovs-dev] [PATCH 2/2] poll-loop: Remove static variable n_waiters.

2011-08-15 Thread Ben Pfaff
When I occasionally look, I usually see about a dozen or so. Not enough to concern me, anyway. Some are probably duplicates (same fd). On Fri, Aug 12, 2011 at 05:06:06PM -0700, Justin Pettit wrote: > It looks fine, but do we have an idea on the number of waiters that typically > exist? > > --J

Re: [ovs-dev] [PATCH 2/2] poll-loop: Remove static variable n_waiters.

2011-08-12 Thread Justin Pettit
It looks fine, but do we have an idea on the number of waiters that typically exist? --Justin On Aug 10, 2011, at 3:05 PM, Ben Pfaff wrote: > It's always a little risky to track the length of a list by hand, because > it is easy to miss a spot where the length can change. So it seems like > a