Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-13 Thread Traynor, Kevin
% libc-2.18.so[.] __clock_gettime Thanks, Kevin. > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno Rajahalme > Sent: Monday, January 12, 2015 6:57 PM > To: Loftus, Ciara > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [P

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-12 Thread Jarno Rajahalme
On Jan 12, 2015, at 9:16 AM, Loftus, Ciara wrote: > Hi, > > After running some performance tests on the latest master, it appears that > this commit has caused netdev DPDK performance to drop significantly (by > 50 > %). Has anybody else seen this? > I saw notified of this last week, and di

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-12 Thread Loftus, Ciara
Hi, After running some performance tests on the latest master, it appears that this commit has caused netdev DPDK performance to drop significantly (by > 50 %). Has anybody else seen this? Regards, Ciara -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jar

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-06 Thread Jarno Rajahalme
On Jan 6, 2015, at 1:20 PM, Ben Pfaff wrote: > On Tue, Jan 06, 2015 at 11:03:15AM -0800, Jarno Rajahalme wrote: >> >> On Jan 5, 2015, at 2:39 PM, Ben Pfaff wrote: >> >>> On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme w

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-06 Thread Ben Pfaff
On Tue, Jan 06, 2015 at 11:03:15AM -0800, Jarno Rajahalme wrote: > > On Jan 5, 2015, at 2:39 PM, Ben Pfaff wrote: > > > On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: > >> On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: > >>> > >>> On Dec 29, 2014, at 2:27 PM, Ben P

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-06 Thread Jarno Rajahalme
On Jan 5, 2015, at 2:39 PM, Ben Pfaff wrote: > On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: >> On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: >>> >>> On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: >>> On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalm

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-05 Thread Ben Pfaff
On Mon, Jan 05, 2015 at 02:15:13PM -0800, Ben Pfaff wrote: > On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: > > > > On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: > > > > > On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: > > >> So far the compressed flow data in

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-05 Thread Ben Pfaff
On Mon, Jan 05, 2015 at 02:08:41PM -0800, Jarno Rajahalme wrote: > > On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: > > > On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: > >> So far the compressed flow data in struct miniflow has been in 32-bit > >> words with a 63-bit map, allow

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-05 Thread Jarno Rajahalme
On Dec 29, 2014, at 2:27 PM, Ben Pfaff wrote: > On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: >> So far the compressed flow data in struct miniflow has been in 32-bit >> words with a 63-bit map, allowing for a maximum size of struct flow of >> 252 bytes. With the forthcoming

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-29 Thread Ben Pfaff
On Wed, Dec 17, 2014 at 10:30:42AM -0800, Jarno Rajahalme wrote: > So far the compressed flow data in struct miniflow has been in 32-bit > words with a 63-bit map, allowing for a maximum size of struct flow of > 252 bytes. With the forthcoming Geneve options this is not sufficient > any more. > >

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Madhu Challa
Thanks for the helpful explanation. Thanks. On Wed, Dec 17, 2014 at 12:45 PM, Jarno Rajahalme wrote: > > > On Dec 17, 2014, at 12:07 PM, Madhu Challa > wrote: > > Jarno, > > I did some simple tests increasing flow_tnl size and trying to match on it > looks good. Thanks for solving this. I have

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Jarno Rajahalme
On Dec 17, 2014, at 12:07 PM, Madhu Challa wrote: > Jarno, > > I did some simple tests increasing flow_tnl size and trying to match on it > looks good. Thanks for solving this. I have a question inline around > miniflow_extract. Other than that the diff looks good to me. > > Thanks. > > On

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2014-12-17 Thread Madhu Challa
Jarno, I did some simple tests increasing flow_tnl size and trying to match on it looks good. Thanks for solving this. I have a question inline around miniflow_extract. Other than that the diff looks good to me. Thanks. On Wed, Dec 17, 2014 at 10:30 AM, Jarno Rajahalme wrote: > > So far the com