Re: [ovs-dev] [PATCH 1/7] ofproto-dpif.at: Fix some races

2014-05-12 Thread YAMAMOTO Takashi
> On Tue, May 13, 2014 at 09:42:02AM +1200, Joe Stringer wrote: >> Is there any general principles behind fixing these? I'm wondering if >> there's a way I can prevent these in future. probably the most typical case is to wait for upcall handler after netdev-dummy/recieve. another typical one is

Re: [ovs-dev] [PATCH 1/7] ofproto-dpif.at: Fix some races

2014-05-12 Thread Ben Pfaff
On Tue, May 13, 2014 at 09:42:02AM +1200, Joe Stringer wrote: > Is there any general principles behind fixing these? I'm wondering if > there's a way I can prevent these in future. If we come up with a general principle like that, maybe we can come up with a systematic way to fix the races without

Re: [ovs-dev] [PATCH 1/7] ofproto-dpif.at: Fix some races

2014-05-12 Thread Joe Stringer
Is there any general principles behind fixing these? I'm wondering if there's a way I can prevent these in future. For example, always sleep after sending packets if no flow exists in the datapath. ___ dev mailing list dev@openvswitch.org http://openvswi

Re: [ovs-dev] [PATCH 1/7] ofproto-dpif.at: Fix some races

2014-05-12 Thread YAMAMOTO Takashi
> On Mon, May 12, 2014 at 11:49:03PM +0900, YAMAMOTO Takashi wrote: >> These races were exposed on my environment by commit c2a77f33. >> ("tests/ofproto-dpif: Use vlog to test dpif behaviour.") >> >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff applied the set, thanks YAMAMOTO Taka

Re: [ovs-dev] [PATCH 1/7] ofproto-dpif.at: Fix some races

2014-05-12 Thread Ben Pfaff
On Mon, May 12, 2014 at 11:49:03PM +0900, YAMAMOTO Takashi wrote: > These races were exposed on my environment by commit c2a77f33. > ("tests/ofproto-dpif: Use vlog to test dpif behaviour.") > > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ d