Re: [ovs-dev] [PATCH 1/5] dpif-netdev: batch packet receiving

2014-06-03 Thread Daniele Di Proietto
Hi Pravin, On May 30, 2014, at 4:53 PM, Pravin Shelar wrote: > We just need to reset mf->map, Can you add api for that ? > infact miniflow_extract() does not read from map, is there need to > initialize it on every packet? You’re right. mini flow_extract() should be enough. > This metadata is sa

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: batch packet receiving

2014-05-30 Thread Pravin Shelar
On Fri, May 23, 2014 at 11:04 AM, Daniele Di Proietto wrote: > This change in dpif-netdev allows faster packet receiving for devices > like netdev-dpdk which implement batch receiving. > > Signed-off-by: Daniele Di Proietto > --- > This patchset allows dpif-netdev to process packets in batches. >

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: batch packet receiving

2014-05-23 Thread Daniele Di Proietto
On May 23, 2014, at 11:37 AM, Ethan Jackson wrote: > I don't totally get why we changed the prototype for > dp_netdev_flow_used() and dp_netdev_count_packets(). All the callers > seem to use the old semantics. You’re right, but next commits use the new semantics. I’ll merge the commits, if y

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: batch packet receiving

2014-05-23 Thread Ethan Jackson
Sounds good. I won't merge any of this series till you've had a chance to look it over. Ethan On Fri, May 23, 2014 at 2:16 PM, Pravin Shelar wrote: > On Fri, May 23, 2014 at 11:37 AM, Ethan Jackson wrote: >> I don't totally get why we changed the prototype for >> dp_netdev_flow_used() and dp_n

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: batch packet receiving

2014-05-23 Thread Pravin Shelar
On Fri, May 23, 2014 at 11:37 AM, Ethan Jackson wrote: > I don't totally get why we changed the prototype for > dp_netdev_flow_used() and dp_netdev_count_packets(). All the callers > seem to use the old semantics. > > I'd replace the variable "int c" with "int cnt" to be consistent with > netdev_

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: batch packet receiving

2014-05-23 Thread Ethan Jackson
I don't totally get why we changed the prototype for dp_netdev_flow_used() and dp_netdev_count_packets(). All the callers seem to use the old semantics. I'd replace the variable "int c" with "int cnt" to be consistent with netdev_rxq_recv(). I also think it's a bit easier to tell what it is. Ot