Re: [ovs-dev] [PATCH 1/4] datapath: Add basic MPLS support to kernel

2012-10-26 Thread Simon Horman
On Fri, Oct 26, 2012 at 05:08:31PM +0900, Isaku Yamahata wrote: > Some inlined comments in case label == 0. I don't find any dependency on it. Thanks Yamahata-san, I agree with both of your comments, I should have fixed these up when adding tracking of the stack depth (which was also suggested by

Re: [ovs-dev] [PATCH 1/4] datapath: Add basic MPLS support to kernel

2012-10-26 Thread Isaku Yamahata
Some inlined comments in case label == 0. I don't find any dependency on it. On Thu, Oct 18, 2012 at 06:02:18PM +0900, Simon Horman wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index a6915fb..e606ae1 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -74,6 +74

Re: [ovs-dev] [PATCH 1/4] datapath: Add basic MPLS support to kernel

2012-10-10 Thread Isaku Yamahata
On Wed, Oct 10, 2012 at 07:31:25PM +0900, Simon Horman wrote: > On Wed, Oct 10, 2012 at 11:57:15AM +0900, Isaku Yamahata wrote: > > On Tue, Oct 09, 2012 at 04:08:32PM +0900, Simon Horman wrote: > > > +static int push_mpls(struct sk_buff *skb, const struct > > > ovs_action_push_mpls *mpls) > > > +{

Re: [ovs-dev] [PATCH 1/4] datapath: Add basic MPLS support to kernel

2012-10-10 Thread Simon Horman
On Wed, Oct 10, 2012 at 11:57:15AM +0900, Isaku Yamahata wrote: > On Tue, Oct 09, 2012 at 04:08:32PM +0900, Simon Horman wrote: > > +static int push_mpls(struct sk_buff *skb, const struct > > ovs_action_push_mpls *mpls) > > +{ > > + u32 l2_size; > > + __be32 *new_mpls_label; > > + > > + if (

Re: [ovs-dev] [PATCH 1/4] datapath: Add basic MPLS support to kernel

2012-10-09 Thread Isaku Yamahata
On Tue, Oct 09, 2012 at 04:08:32PM +0900, Simon Horman wrote: > +static int push_mpls(struct sk_buff *skb, const struct ovs_action_push_mpls > *mpls) > +{ > + u32 l2_size; > + __be32 *new_mpls_label; > + > + if (skb_cow_head(skb, MPLS_HLEN) < 0) { > + kfree_skb(skb); > +