On Aug 30, 2013, at 9:48 PM, Simon Horman wrote:
> On Fri, Aug 30, 2013 at 01:40:16PM -0700, Jarno Rajahalme wrote:
>> +LIST_FOR_EACH(bucket, list_node, &gm->buckets) {
>> +++n_buckets;
>
> Any reason you favour a pre-increment over a post-increment.
> I realise it makes no
On Fri, Aug 30, 2013 at 01:40:16PM -0700, Jarno Rajahalme wrote:
> Indirect groups can have at most one bucket.
>
> Signed-off-by: Jarno Rajahalme
Good catch, thank you.
I chose to just add this instead, though:
+if (gm->type == OFPGT11_INDIRECT && !list_is_short(&gm->buckets)) {
+
On Fri, Aug 30, 2013 at 01:40:16PM -0700, Jarno Rajahalme wrote:
> Indirect groups can have at most one bucket.
>
> Signed-off-by: Jarno Rajahalme
Reviewed-by: Simon Horman
> ---
> lib/ofp-parse.c | 14 +++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/lib/
