Re: [ovs-dev] [PATCH 1/2] ovsdb windows: Allow online compacting

2016-11-01 Thread Ben Pfaff
On Tue, Nov 01, 2016 at 08:26:06PM -0700, Ben Pfaff wrote: > +/* Replace original file by the temporary file. > + * > + * We support two strategies: > + * > + * - The preferred strategy is to rename the temporary file over the > + * original one in-place, then clos

Re: [ovs-dev] [PATCH 1/2] ovsdb windows: Allow online compacting

2016-11-01 Thread Ben Pfaff
On Thu, Oct 27, 2016 at 09:45:42PM +, Alin Serdean wrote: > This patch allows online compacting to be done under Windows. > > To achieve the above we need to close all file handles before trying to > rename the file, switch from rename to MoveFileEx (because rename/MoveFile > fails if the dest