Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-09-08 Thread Jesse Gross
On Tue, Aug 23, 2011 at 11:11 PM, Simon Horman wrote: > On Tue, Aug 02, 2011 at 01:56:22PM +0700, Jesse Gross wrote: >> On Tue, Aug 2, 2011 at 12:01 PM, Simon Horman wrote: >> > Hi, >> > >> > in an effort to move things forward I decided to take the liberty >> > of posting a fresh version of this

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-08-23 Thread Simon Horman
On Tue, Aug 02, 2011 at 01:56:22PM +0700, Jesse Gross wrote: > On Tue, Aug 2, 2011 at 12:01 PM, Simon Horman wrote: > > Hi, > > > > in an effort to move things forward I decided to take the liberty > > of posting a fresh version of this patch which addresses each > > of the issues that Jesse raise

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-08-01 Thread Jesse Gross
On Tue, Aug 2, 2011 at 12:01 PM, Simon Horman wrote: > Hi, > > in an effort to move things forward I decided to take the liberty > of posting a fresh version of this patch which addresses each > of the issues that Jesse raises below. Thanks for picking this up Simon. > On Fri, Jul 22, 2011 at 02

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-08-01 Thread Simon Horman
Hi, in an effort to move things forward I decided to take the liberty of posting a fresh version of this patch which addresses each of the issues that Jesse raises below. On Fri, Jul 22, 2011 at 02:18:47PM -0700, Jesse Gross wrote: > On Wed, Jul 13, 2011 at 10:05 PM, Valient Gough wrote: > > dif

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-22 Thread Jesse Gross
On Fri, Jul 22, 2011 at 2:22 PM, Ben Pfaff wrote: > On Fri, Jul 22, 2011 at 2:18 PM, Jesse Gross wrote: >> On Wed, Jul 13, 2011 at 10:05 PM, Valient Gough wrote: >>> @@ -628,7 +768,8 @@ static int capwap_frag_match(struct inet_frag_queue >>> *ifq, void *a_) >>>        struct frag_match *a = a_;

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-22 Thread Ben Pfaff
On Fri, Jul 22, 2011 at 2:18 PM, Jesse Gross wrote: > On Wed, Jul 13, 2011 at 10:05 PM, Valient Gough wrote: >> @@ -628,7 +768,8 @@ static int capwap_frag_match(struct inet_frag_queue >> *ifq, void *a_) >>        struct frag_match *a = a_; >>        struct frag_match *b = &ifq_cast(ifq)->match;

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-22 Thread Jesse Gross
On Wed, Jul 13, 2011 at 10:05 PM, Valient Gough wrote: > diff --git a/datapath/vport-capwap.c b/datapath/vport-capwap.c > index f0bb327..161c6d4 100644 > --- a/datapath/vport-capwap.c > +++ b/datapath/vport-capwap.c > +/* > + * Should be sized as multiple of u32, for hash functions. > + */ >  stru

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-11 Thread Jesse Gross
On Sun, Jul 10, 2011 at 6:18 PM, Valient Gough wrote: > Add tunnel key support to CAPWAP vport.  Uses the optional WSI field in a > CAPWAP header to store a 64bit key.  It can also be used without keys, in > which > case it is backward compatible with the old code.  Documentation about the > WSI

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-10 Thread Valient Gough
Thanks Jesse. Your comment about skb_pull makes sense now. I'm sending an updated patch which addresses your comments and fixes fragment handling. -- Valient ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/1] datapath: add key support to CAPWAP tunnel

2011-07-08 Thread Jesse Gross
On Sun, Jul 3, 2011 at 5:01 PM, Valient Gough wrote: > Add tunnel key support to CAPWAP vport.  Uses the optional WSI field in a > CAPWAP header to store a 64bit key.  It can also be used without keys, in > which > case it is backward compatible with the old code.  Documentation about the > WSI f