Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-05 Thread Kyle Mestery (kmestery)
On Sep 5, 2012, at 1:03 PM, Jesse Gross wrote: > On Wed, Sep 5, 2012 at 10:17 AM, Kyle Mestery (kmestery) > wrote: >> On Sep 4, 2012, at 8:40 PM, Jesse Gross wrote: >>> On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery) >>> wrote: On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote: > On

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-05 Thread Jesse Gross
On Wed, Sep 5, 2012 at 10:17 AM, Kyle Mestery (kmestery) wrote: > On Sep 4, 2012, at 8:40 PM, Jesse Gross wrote: >> On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery) >> wrote: >>> On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote: On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote:

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-05 Thread Kyle Mestery (kmestery)
On Sep 4, 2012, at 8:40 PM, Jesse Gross wrote: > On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery) > wrote: >> On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote: >>> On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote: diff --git a/datapath/actions.c b/datapath/actions.c index 208f26

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-04 Thread Kyle Mestery (kmestery)
On Sep 4, 2012, at 8:40 PM, Jesse Gross wrote: > On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery) > wrote: >> On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote: >>> On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote: diff --git a/datapath/actions.c b/datapath/actions.c index 208f26

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-04 Thread Jesse Gross
On Tue, Sep 4, 2012 at 12:24 PM, Kyle Mestery (kmestery) wrote: > On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote: >> On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote: >>> diff --git a/datapath/actions.c b/datapath/actions.c >>> index 208f260..83382b9 100644 >>> --- a/datapath/actions.c >>> +++

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-04 Thread Kyle Mestery (kmestery)
On Sep 3, 2012, at 3:43 PM, Jesse Gross wrote: > On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote: >> This is a first pass at providing a tun_key which can be >> used as the basis for flow-based tunnelling. The tun_key >> includes and replaces the tun_id in both struct ovs_skb_cb >> and struc

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-03 Thread Kyle Mestery (kmestery)
On Sep 3, 2012, at 3:56 PM, Jesse Gross wrote: > Hi Kyle, > > Sorry again about the long delay in getting back to you on this and > thanks for being so patient. I definitely intend to be much quicker > about future patches. > No worries on my end! I was just hoping to try and start getting some

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-03 Thread Jesse Gross
Hi Kyle, Sorry again about the long delay in getting back to you on this and thanks for being so patient. I definitely intend to be much quicker about future patches. I think your approach of doing incremental changes is a good one since the full set of changes is pretty large. The one thing th

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-09-03 Thread Jesse Gross
On Wed, Aug 29, 2012 at 7:00 AM, Kyle Mestery wrote: > This is a first pass at providing a tun_key which can be > used as the basis for flow-based tunnelling. The tun_key > includes and replaces the tun_id in both struct ovs_skb_cb > and struct sw_tun_key. > > In ovs_skb_cb tun_key is a pointer as

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-31 Thread Kyle Mestery (kmestery)
Jesse: Are you going to have a chance to review these next week? Can you also comment on if you want to iterate over all of Simon's original patches, or go down the path I started with these patches, which was to try and get the initial tun_key changes in, leaving existing functionality in place,

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-29 Thread Simon Horman
On Wed, Aug 29, 2012 at 10:00:45AM -0400, Kyle Mestery wrote: > This is a first pass at providing a tun_key which can be > used as the basis for flow-based tunnelling. The tun_key > includes and replaces the tun_id in both struct ovs_skb_cb > and struct sw_tun_key. > > In ovs_skb_cb tun_key is a p

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-29 Thread Kyle Mestery (kmestery)
On Aug 28, 2012, at 9:08 PM, Jesse Gross wrote: > On Sun, Aug 26, 2012 at 6:55 PM, Kyle Mestery (kmestery) > wrote: >> >> On Aug 21, 2012, at 2:05 AM, Simon Horman wrote: >> >>> On Mon, Aug 13, 2012 at 12:23:51PM -0400, Kyle Mestery wrote: This is a first pass at providing a tun_key which c

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-28 Thread Jesse Gross
On Sun, Aug 26, 2012 at 6:55 PM, Kyle Mestery (kmestery) wrote: > > On Aug 21, 2012, at 2:05 AM, Simon Horman wrote: > >> On Mon, Aug 13, 2012 at 12:23:51PM -0400, Kyle Mestery wrote: >>> This is a first pass at providing a tun_key which can be >>> used as the basis for flow-based tunnelling. The

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-26 Thread Kyle Mestery (kmestery)
On Aug 21, 2012, at 2:05 AM, Simon Horman wrote: > On Mon, Aug 13, 2012 at 12:23:51PM -0400, Kyle Mestery wrote: >> This is a first pass at providing a tun_key which can be >> used as the basis for flow-based tunnelling. The tun_key >> includes and replaces the tun_id in both struct ovs_skb_cb >>

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-21 Thread Ben Pfaff
On Tue, Aug 21, 2012 at 04:05:12PM +0900, Simon Horman wrote: > 2. Ben Pfaff recently pointed out to me that OVS (almost?) consistently >prefixes hexadecimal strings with "0x". ... I try to do it consistently[*]. If you find places where 0x is omitted, let me know. [*] Except for MAC addres

Re: [ovs-dev] [PATCH 1/1] Add support for tun_key to OVS datapath

2012-08-21 Thread Simon Horman
On Mon, Aug 13, 2012 at 12:23:51PM -0400, Kyle Mestery wrote: > This is a first pass at providing a tun_key which can be > used as the basis for flow-based tunnelling. The tun_key > includes and replaces the tun_id in both struct ovs_skb_cb > and struct sw_tun_key. > > In ovs_skb_cb tun_key is a p