Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall structure.

2016-10-11 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Jarno Rajahalme [mailto:ja...@ovn.org] >Sent: Monday, October 10, 2016 9:01 PM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall >structure. > >How

Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall structure.

2016-10-10 Thread Jarno Rajahalme
rakash. > >> -Original Message- >> From: Jarno Rajahalme [mailto:ja...@ovn.org] >> Sent: Friday, October 7, 2016 10:11 PM >> To: Bodireddy, Bhanuprakash >> Cc: dev@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_up

Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall structure.

2016-10-10 Thread Bodireddy, Bhanuprakash
om: Jarno Rajahalme [mailto:ja...@ovn.org] >Sent: Friday, October 7, 2016 10:11 PM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall >structure. > >CodingStyle.md instructs to group struct mem

Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall structure.

2016-10-07 Thread Jarno Rajahalme
CodingStyle.md instructs to group struct members into related groups. Also, changing the relative order of pointers should not make any difference. Could you achieve the same by reordering just the members above the ‘DPIF_UC_ACTION only.’ comment? Jarno > On Oct 7, 2016, at 9:17 AM, Bhanupra