On Wed, Apr 09, 2014 at 01:46:48PM -0700, Jarno Rajahalme wrote:
> > There is a doubled ';' in commit_set_ipv4_action():
> > +key.ipv4_src = base->nw_src & wc->masks.nw_src;;
> >
> > The beginning of commit_set_ipv4_action() first asserts:
> >!((a ^ b) & ~c)
> > and then checks
Ben,
Thanks for your review. Some comments below,
Jarno
On Apr 9, 2014, at 1:19 PM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:49PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>
> Consider this code from commit_set_ether_addr_action():
>
>bool have_mask_src
On Tue, Apr 08, 2014 at 04:38:49PM -0700, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
Consider this code from commit_set_ether_addr_action():
bool have_mask_src = !eth_addr_is_zero(wc->masks.dl_src);
bool have_mask_dst = !eth_addr_is_zero(wc->masks.dl_dst);
...
memcpy(b
