Re: [ovs-dev] [PATCH 04/24] ofp-util: Add ofputil_pull_ofp12_match()

2012-07-24 Thread Simon Horman
On Tue, Jul 24, 2012 at 10:33:01PM -0700, Ben Pfaff wrote: > On Mon, Jul 23, 2012 at 03:16:33PM +0900, Simon Horman wrote: > > This may be used by both ofputil_decode_flow_mod() and > > ofputil_decode_packet_in() > > > > Signed-off-by: Simon Horman > > Seems reasonable, but can you use __ as a s

Re: [ovs-dev] [PATCH 04/24] ofp-util: Add ofputil_pull_ofp12_match()

2012-07-24 Thread Ben Pfaff
On Mon, Jul 23, 2012 at 03:16:33PM +0900, Simon Horman wrote: > This may be used by both ofputil_decode_flow_mod() and > ofputil_decode_packet_in() > > Signed-off-by: Simon Horman Seems reasonable, but can you use __ as a suffix instead of a prefix since the C standard reserves __-prefixed ident