.
Thanks,
Sam
From: Samuel Ghinet
Sent: Thursday, August 21, 2014 10:45 PM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH 01/15] datapath-windows: Update CodingStyle
Also, I think it would be cleaner & would improve code readabilit
___
From: Samuel Ghinet
Sent: Thursday, August 21, 2014 9:45 PM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH 01/15] datapath-windows: Update CodingStyle
Thanks Nithin for your opinions on coding style!
[QUOTE]
The guideline is fine. It seems to be a rewording o
Thanks Nithin for your opinions on coding style!
[QUOTE]
The guideline is fine. It seems to be a rewording of the existing guideline,
but it is ok to do it.
[/QUOTE]
Except, the current coding style says:
"For types, use all upper case for all letters with words separated by '_'. If
camel casin
Samuel,
Thanks for writing this up. I don't agree with some of them, but do like some
of the suggestions. I am actually encouraged that the CodingStyle for
datapath-windows is evolving.
> - For types, use all upper case for all letters with words separated by '_'.
> If
> - camel casing is pre
Hello Alin,
These are mere suggestions I have, and I am eager to hear any feedback on them.
I am certainly not trying to impose on the community to use a specific coding
style rule!
I am very curious on any coding style I have suggested that other people may
agree upon.
Thanks!
Sam
___
Hi Sam,
Just some pointers from me:
- format the text up to 79 characters.
- " Do not use space after "(" or before ")" ", people using vi would have a
harder time
- "o) "_" prefix for private functions", I don't quite understand. Do you mean
static?
Alin.
-Mesaj original-
De la: dev
