Re: [ovs-dev] [PATCH] vtep: add source node replication support.

2016-04-15 Thread Darrell Ball
Thanks for catching that; I did not notice the version line at the end of this schema file and mistakenly added what I thought was absent. On Fri, Apr 15, 2016 at 4:38 PM, Bruce Davie wrote: > Good, sounds like we’re in sync. One other thing I noticed belatedly. The > file vtep.ovsschema has tw

Re: [ovs-dev] [PATCH] vtep: add source node replication support.

2016-04-15 Thread Bruce Davie
Good, sounds like we’re in sync. One other thing I noticed belatedly. The file vtep.ovsschema has two entries for version: line 3: "version": "1.1.0”, and line 310: "version": “1.5.1" I don’t think this is what we want. Line 3 should not have been added. And since this modification adds a col

Re: [ovs-dev] [PATCH] vtep: add source node replication support.

2016-04-15 Thread Darrell Ball
Thank you Bruce for your feedback and taking the time On Fri, Apr 15, 2016 at 12:40 PM, Bruce Davie wrote: > Darrell, > Thanks for taking this on, we’ve known for a while that this should have > been cleaned up. > > I have a few comments and questions. > > First, who decides what mode a switc

Re: [ovs-dev] [PATCH] vtep: add source node replication support.

2016-04-15 Thread Bruce Davie
Darrell, Thanks for taking this on, we’ve known for a while that this should have been cleaned up. I have a few comments and questions. First, who decides what mode a switch is in? In most, if not all fields, either the VTEP or the controller is expected to write the value. In this case, so